All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
Cc: Robin Murphy <robin.murphy@arm.com>,
	Chris Morgan <macromorgan@hotmail.com>,
	Markus Reichl <m.reichl@fivetechno.de>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-amarula@amarulasolutions.com, Da Xue <da.xue@libretech.co>,
	dsx724 <da@lessconfused.com>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Suniel Mahesh <sunil@amarulasolutions.com>,
	Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
Subject: Re: [PATCH 1/1] arm64: dts: rockchip: increase spi-max-frequency of nor flash for roc-rk3399-pc
Date: Wed, 23 Nov 2022 15:04:43 +0100	[thread overview]
Message-ID: <4981984.iIbC2pHGDl@phil> (raw)
In-Reply-To: <20221123094827.250657-2-abbaraju.manojsai@amarulasolutions.com>

Hi Manoj,

Am Mittwoch, 23. November 2022, 10:48:27 CET schrieb Manoj Sai:
> Increase the spi-max-frequency of nor flash from 10Mhz to 30Mhz,this improves the
> flash raw write speed by 0.9 MB/s to 1.6MB/s and the time taken to write is
> get reduced from 36 seconds to 20 seconds.
> 
> Signed-off-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
> Signed-off-by: Da Xue <da.xue@libretech.co>
> Signed-off-by: dsx724 <da@lessconfused.com>

who are these other people? :-)

I.e. it looks like you're the author of the patch,
and so it should only have your Signed-off-by line.

If Da Xue and dsx724 have tested / reviewed the change, they
should respond individually to the posted patch with
either a "Reviewed-by: ..." or "Tested-by: ..." line.


Thanks
Heiko

> ---
>  arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
> index 2f4b1b2e3ac7..8fd808a0df85 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
> @@ -735,7 +735,7 @@ &spi1 {
>  	flash@0 {
>  		compatible = "jedec,spi-nor";
>  		reg = <0>;
> -		spi-max-frequency = <10000000>;
> +		spi-max-frequency = <30000000>;
>  	};
>  };
>  
> 





_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
Cc: Robin Murphy <robin.murphy@arm.com>,
	Chris Morgan <macromorgan@hotmail.com>,
	Markus Reichl <m.reichl@fivetechno.de>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-amarula@amarulasolutions.com, Da Xue <da.xue@libretech.co>,
	dsx724 <da@lessconfused.com>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Suniel Mahesh <sunil@amarulasolutions.com>,
	Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
Subject: Re: [PATCH 1/1] arm64: dts: rockchip: increase spi-max-frequency of nor flash for roc-rk3399-pc
Date: Wed, 23 Nov 2022 15:04:43 +0100	[thread overview]
Message-ID: <4981984.iIbC2pHGDl@phil> (raw)
In-Reply-To: <20221123094827.250657-2-abbaraju.manojsai@amarulasolutions.com>

Hi Manoj,

Am Mittwoch, 23. November 2022, 10:48:27 CET schrieb Manoj Sai:
> Increase the spi-max-frequency of nor flash from 10Mhz to 30Mhz,this improves the
> flash raw write speed by 0.9 MB/s to 1.6MB/s and the time taken to write is
> get reduced from 36 seconds to 20 seconds.
> 
> Signed-off-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
> Signed-off-by: Da Xue <da.xue@libretech.co>
> Signed-off-by: dsx724 <da@lessconfused.com>

who are these other people? :-)

I.e. it looks like you're the author of the patch,
and so it should only have your Signed-off-by line.

If Da Xue and dsx724 have tested / reviewed the change, they
should respond individually to the posted patch with
either a "Reviewed-by: ..." or "Tested-by: ..." line.


Thanks
Heiko

> ---
>  arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
> index 2f4b1b2e3ac7..8fd808a0df85 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
> @@ -735,7 +735,7 @@ &spi1 {
>  	flash@0 {
>  		compatible = "jedec,spi-nor";
>  		reg = <0>;
> -		spi-max-frequency = <10000000>;
> +		spi-max-frequency = <30000000>;
>  	};
>  };
>  
> 





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
Cc: Robin Murphy <robin.murphy@arm.com>,
	Chris Morgan <macromorgan@hotmail.com>,
	Markus Reichl <m.reichl@fivetechno.de>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-amarula@amarulasolutions.com, Da Xue <da.xue@libretech.co>,
	dsx724 <da@lessconfused.com>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Suniel Mahesh <sunil@amarulasolutions.com>,
	Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
Subject: Re: [PATCH 1/1] arm64: dts: rockchip: increase spi-max-frequency of nor flash for roc-rk3399-pc
Date: Wed, 23 Nov 2022 15:04:43 +0100	[thread overview]
Message-ID: <4981984.iIbC2pHGDl@phil> (raw)
In-Reply-To: <20221123094827.250657-2-abbaraju.manojsai@amarulasolutions.com>

Hi Manoj,

Am Mittwoch, 23. November 2022, 10:48:27 CET schrieb Manoj Sai:
> Increase the spi-max-frequency of nor flash from 10Mhz to 30Mhz,this improves the
> flash raw write speed by 0.9 MB/s to 1.6MB/s and the time taken to write is
> get reduced from 36 seconds to 20 seconds.
> 
> Signed-off-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
> Signed-off-by: Da Xue <da.xue@libretech.co>
> Signed-off-by: dsx724 <da@lessconfused.com>

who are these other people? :-)

I.e. it looks like you're the author of the patch,
and so it should only have your Signed-off-by line.

If Da Xue and dsx724 have tested / reviewed the change, they
should respond individually to the posted patch with
either a "Reviewed-by: ..." or "Tested-by: ..." line.


Thanks
Heiko

> ---
>  arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
> index 2f4b1b2e3ac7..8fd808a0df85 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
> @@ -735,7 +735,7 @@ &spi1 {
>  	flash@0 {
>  		compatible = "jedec,spi-nor";
>  		reg = <0>;
> -		spi-max-frequency = <10000000>;
> +		spi-max-frequency = <30000000>;
>  	};
>  };
>  
> 





  reply	other threads:[~2022-11-23 14:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-23  9:48 [PATCH 0/1] Increase spi-max-frequency of nor flash for roc-rk3399-pc Manoj Sai
2022-11-23  9:48 ` Manoj Sai
2022-11-23  9:48 ` Manoj Sai
2022-11-23  9:48 ` [PATCH 1/1] arm64: dts: rockchip: increase " Manoj Sai
2022-11-23  9:48   ` Manoj Sai
2022-11-23  9:48   ` Manoj Sai
2022-11-23 14:04   ` Heiko Stuebner [this message]
2022-11-23 14:04     ` Heiko Stuebner
2022-11-23 14:04     ` Heiko Stuebner
2022-11-23 14:15     ` Krzysztof Kozlowski
2022-11-23 14:15       ` Krzysztof Kozlowski
2022-11-23 14:15       ` Krzysztof Kozlowski
2022-11-24  7:27   ` [PATCH v2] " Manoj Sai
2022-11-24  7:27     ` Manoj Sai
2022-11-24  7:27     ` Manoj Sai
2023-01-10 14:04     ` Heiko Stuebner
2023-01-10 14:04       ` Heiko Stuebner
2023-01-10 14:04       ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4981984.iIbC2pHGDl@phil \
    --to=heiko@sntech.de \
    --cc=abbaraju.manojsai@amarulasolutions.com \
    --cc=da.xue@libretech.co \
    --cc=da@lessconfused.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jagan@amarulasolutions.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-amarula@amarulasolutions.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=m.reichl@fivetechno.de \
    --cc=macromorgan@hotmail.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=sunil@amarulasolutions.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.