* [PATCH] x86: UV fix uv_flush_send_and_wait
@ 2009-01-29 21:35 Cliff Wickman
2009-01-30 15:02 ` Ingo Molnar
0 siblings, 1 reply; 4+ messages in thread
From: Cliff Wickman @ 2009-01-29 21:35 UTC (permalink / raw)
To: linux-kernel; +Cc: mingo, tj
From: Cliff Wickman <cpw@sgi.com>
uv_flush_send_and_wait() should return a pointer if the broadcast
remote tlb shootdown requests fail. That causes the conventional IPI
method of shootdown to be used.
Diffed against 2.6.29-rc2
(Ingo's tree)
Signed-off-by: Cliff Wickman <cpw@sgi.com>
---
arch/x86/kernel/tlb_uv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/arch/x86/kernel/tlb_uv.c
===================================================================
--- linux.orig/arch/x86/kernel/tlb_uv.c
+++ linux/arch/x86/kernel/tlb_uv.c
@@ -259,7 +259,7 @@ const struct cpumask *uv_flush_send_and_
* the cpu's, all of which are still in the mask.
*/
__get_cpu_var(ptcstats).ptc_i++;
- return 0;
+ return flush_mask;
}
/*
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: UV fix uv_flush_send_and_wait
2009-01-29 21:35 [PATCH] x86: UV fix uv_flush_send_and_wait Cliff Wickman
@ 2009-01-30 15:02 ` Ingo Molnar
2009-01-30 15:20 ` Tejun Heo
0 siblings, 1 reply; 4+ messages in thread
From: Ingo Molnar @ 2009-01-30 15:02 UTC (permalink / raw)
To: Cliff Wickman; +Cc: linux-kernel, tj
* Cliff Wickman <cpw@sgi.com> wrote:
> From: Cliff Wickman <cpw@sgi.com>
>
> uv_flush_send_and_wait() should return a pointer if the broadcast
> remote tlb shootdown requests fail. That causes the conventional IPI
> method of shootdown to be used.
>
> Diffed against 2.6.29-rc2
> (Ingo's tree)
>
> Signed-off-by: Cliff Wickman <cpw@sgi.com>
> ---
> arch/x86/kernel/tlb_uv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to tip/x86/urgnet, thanks Cliff!
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: UV fix uv_flush_send_and_wait
2009-01-30 15:02 ` Ingo Molnar
@ 2009-01-30 15:20 ` Tejun Heo
2009-01-30 15:24 ` Ingo Molnar
0 siblings, 1 reply; 4+ messages in thread
From: Tejun Heo @ 2009-01-30 15:20 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Cliff Wickman, linux-kernel
Ingo Molnar wrote:
> * Cliff Wickman <cpw@sgi.com> wrote:
>
>> From: Cliff Wickman <cpw@sgi.com>
>>
>> uv_flush_send_and_wait() should return a pointer if the broadcast
>> remote tlb shootdown requests fail. That causes the conventional IPI
>> method of shootdown to be used.
>>
>> Diffed against 2.6.29-rc2
>> (Ingo's tree)
>>
>> Signed-off-by: Cliff Wickman <cpw@sgi.com>
>> ---
>> arch/x86/kernel/tlb_uv.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Applied to tip/x86/urgnet, thanks Cliff!
Ingo, this patch shouldn't go into x86/urgent. This patch is to fix a
bug introduced by a patch in the percpu branch and not applicable to
x86/urgent.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: UV fix uv_flush_send_and_wait
2009-01-30 15:20 ` Tejun Heo
@ 2009-01-30 15:24 ` Ingo Molnar
0 siblings, 0 replies; 4+ messages in thread
From: Ingo Molnar @ 2009-01-30 15:24 UTC (permalink / raw)
To: Tejun Heo; +Cc: Cliff Wickman, linux-kernel
* Tejun Heo <tj@kernel.org> wrote:
> Ingo Molnar wrote:
> > * Cliff Wickman <cpw@sgi.com> wrote:
> >
> >> From: Cliff Wickman <cpw@sgi.com>
> >>
> >> uv_flush_send_and_wait() should return a pointer if the broadcast
> >> remote tlb shootdown requests fail. That causes the conventional IPI
> >> method of shootdown to be used.
> >>
> >> Diffed against 2.6.29-rc2
> >> (Ingo's tree)
> >>
> >> Signed-off-by: Cliff Wickman <cpw@sgi.com>
> >> ---
> >> arch/x86/kernel/tlb_uv.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Applied to tip/x86/urgnet, thanks Cliff!
>
> Ingo, this patch shouldn't go into x86/urgent. This patch is to fix a
> bug introduced by a patch in the percpu branch and not applicable to
> x86/urgent.
ah, indeed, the UV cleanup you did. Please pick up this fix then too into
your tree - the two should go together. I dropped it from x86/urgent.
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-01-30 15:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-29 21:35 [PATCH] x86: UV fix uv_flush_send_and_wait Cliff Wickman
2009-01-30 15:02 ` Ingo Molnar
2009-01-30 15:20 ` Tejun Heo
2009-01-30 15:24 ` Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.