From: Roel Kluin <roel.kluin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Mauro Carvalho Chehab <mchehab-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH] saa7146_i2c: saa7146_i2c_transfer() wrong?
Date: Sat, 31 Jan 2009 17:52:05 +0100 [thread overview]
Message-ID: <498481B5.4030702@gmail.com> (raw)
vi drivers/media/common/saa7146_i2c.c +292
in saa7146_i2c_transfer(..., int retries)
{
int address_err = 0;
do {
...
if (...)
address_err++;
...
} while (retries--);
/* if every retry had an address error, exit right away */
if (address_err == retries) {
goto out;
}
...
}
this is wrong, isn't it?
WARNING: multiple messages have this Message-ID (diff)
From: Roel Kluin <roel.kluin@gmail.com>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: linux-media@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: [PATCH] saa7146_i2c: saa7146_i2c_transfer() wrong?
Date: Sat, 31 Jan 2009 17:52:05 +0100 [thread overview]
Message-ID: <498481B5.4030702@gmail.com> (raw)
vi drivers/media/common/saa7146_i2c.c +292
in saa7146_i2c_transfer(..., int retries)
{
int address_err = 0;
do {
...
if (...)
address_err++;
...
} while (retries--);
/* if every retry had an address error, exit right away */
if (address_err == retries) {
goto out;
}
...
}
this is wrong, isn't it?
next reply other threads:[~2009-01-31 16:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-31 16:52 Roel Kluin [this message]
2009-01-31 16:52 ` [PATCH] saa7146_i2c: saa7146_i2c_transfer() wrong? Roel Kluin
[not found] ` <498481B5.4030702-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-02-01 10:55 ` Jean Delvare
2009-02-01 10:55 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498481B5.4030702@gmail.com \
--to=roel.kluin-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mchehab-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.