From: Tejun Heo <tj@kernel.org>
To: jeff@garzik.org, linux-ide@vger.kernel.org,
jens.axboe@oracle.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org,
James.Bottomley@HansenPartnership.com, Mauelshagen@redhat.c
Subject: [PATCH 3/3] dmraid: make nv use alt_size if available
Date: Sun, 01 Feb 2009 12:01:04 +0900 [thread overview]
Message-ID: <49851070.7030306@kernel.org> (raw)
In-Reply-To: <49851012.8070904@kernel.org>
nv puts metatdata at the end of a device, so it's important that
dmraid and BIOS agree where the end of the device is. Later kernel
exports the BIOS as via sysfs and it's available as di->alt_sectors.
Use it if available.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
lib/format/ataraid/nv.c | 15 +++++++++++----
lib/format/ataraid/nv.h | 2 +-
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/lib/format/ataraid/nv.c b/lib/format/ataraid/nv.c
index 893cc3a..bd4589c 100644
--- a/lib/format/ataraid/nv.c
+++ b/lib/format/ataraid/nv.c
@@ -216,9 +216,16 @@ static int setup_rd(struct lib_context *lc, struct raid_dev *rd,
static struct raid_dev *
nv_read(struct lib_context *lc, struct dev_info *di)
{
- return read_raid_dev(lc, di, NULL,
- sizeof(struct nv), NV_CONFIGOFFSET,
- to_cpu, is_nv, NULL, setup_rd, handler);
+ uint64_t sectors = di->alt_sectors ? di->alt_sectors : di->sectors;
+ struct raid_dev *rd;
+
+ rd = read_raid_dev(lc, di, NULL, sizeof(struct nv),
+ NV_CONFIGOFFSET(sectors),
+ to_cpu, is_nv, NULL, setup_rd, handler);
+ if (rd && di->alt_sectors)
+ log_notice(lc, "%s: using BIOS sectors %"PRIu64,
+ di->path, di->alt_sectors);
+ return rd;
}
/* Write private RAID metadata to device */
@@ -427,7 +434,7 @@ setup_rd(struct lib_context *lc, struct raid_dev *rd,
if (!(rd->meta_areas = alloc_meta_areas(lc, rd, handler, 1)))
return 0;
- rd->meta_areas->offset = NV_CONFIGOFFSET >> 9;
+ rd->meta_areas->offset = info->u64 >> 9;
rd->meta_areas->size = sizeof(*nv);
rd->meta_areas->area = (void *) nv;
diff --git a/lib/format/ataraid/nv.h b/lib/format/ataraid/nv.h
index 020900c..cca32da 100644
--- a/lib/format/ataraid/nv.h
+++ b/lib/format/ataraid/nv.h
@@ -23,7 +23,7 @@
#include <stdint.h>
-#define NV_CONFIGOFFSET ((di->sectors - 2) << 9)
+#define NV_CONFIGOFFSET(sects) (((sects) - 2) << 9)
#define NV_DATAOFFSET 0
#define NV_ID_LENGTH 8
--
1.6.0.2
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: jeff@garzik.org, linux-ide@vger.kernel.org,
jens.axboe@oracle.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org,
James.Bottomley@HansenPartnership.com, Mauelshagen@RedHat.com,
dm-devel@RedHat.com
Subject: [PATCH 3/3] dmraid: make nv use alt_size if available
Date: Sun, 01 Feb 2009 12:01:04 +0900 [thread overview]
Message-ID: <49851070.7030306@kernel.org> (raw)
In-Reply-To: <49851012.8070904@kernel.org>
nv puts metatdata at the end of a device, so it's important that
dmraid and BIOS agree where the end of the device is. Later kernel
exports the BIOS as via sysfs and it's available as di->alt_sectors.
Use it if available.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
lib/format/ataraid/nv.c | 15 +++++++++++----
lib/format/ataraid/nv.h | 2 +-
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/lib/format/ataraid/nv.c b/lib/format/ataraid/nv.c
index 893cc3a..bd4589c 100644
--- a/lib/format/ataraid/nv.c
+++ b/lib/format/ataraid/nv.c
@@ -216,9 +216,16 @@ static int setup_rd(struct lib_context *lc, struct raid_dev *rd,
static struct raid_dev *
nv_read(struct lib_context *lc, struct dev_info *di)
{
- return read_raid_dev(lc, di, NULL,
- sizeof(struct nv), NV_CONFIGOFFSET,
- to_cpu, is_nv, NULL, setup_rd, handler);
+ uint64_t sectors = di->alt_sectors ? di->alt_sectors : di->sectors;
+ struct raid_dev *rd;
+
+ rd = read_raid_dev(lc, di, NULL, sizeof(struct nv),
+ NV_CONFIGOFFSET(sectors),
+ to_cpu, is_nv, NULL, setup_rd, handler);
+ if (rd && di->alt_sectors)
+ log_notice(lc, "%s: using BIOS sectors %"PRIu64,
+ di->path, di->alt_sectors);
+ return rd;
}
/* Write private RAID metadata to device */
@@ -427,7 +434,7 @@ setup_rd(struct lib_context *lc, struct raid_dev *rd,
if (!(rd->meta_areas = alloc_meta_areas(lc, rd, handler, 1)))
return 0;
- rd->meta_areas->offset = NV_CONFIGOFFSET >> 9;
+ rd->meta_areas->offset = info->u64 >> 9;
rd->meta_areas->size = sizeof(*nv);
rd->meta_areas->area = (void *) nv;
diff --git a/lib/format/ataraid/nv.h b/lib/format/ataraid/nv.h
index 020900c..cca32da 100644
--- a/lib/format/ataraid/nv.h
+++ b/lib/format/ataraid/nv.h
@@ -23,7 +23,7 @@
#include <stdint.h>
-#define NV_CONFIGOFFSET ((di->sectors - 2) << 9)
+#define NV_CONFIGOFFSET(sects) (((sects) - 2) << 9)
#define NV_DATAOFFSET 0
#define NV_ID_LENGTH 8
--
1.6.0.2
next prev parent reply other threads:[~2009-02-01 3:01 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-01 2:55 [PATCHSET] block,scsi,libata: implement alt_size Tejun Heo
2009-02-01 2:55 ` Tejun Heo
2009-02-01 2:55 ` [PATCH 1/3] block: add alt_size Tejun Heo
2009-02-01 2:55 ` Tejun Heo
2009-02-01 2:55 ` [PATCH 2/3] scsi: add scsi_device->alt_capacity Tejun Heo
2009-02-01 2:55 ` Tejun Heo
2009-02-01 2:55 ` [PATCH 3/3] libata: export HPA size as alt_size Tejun Heo
2009-02-01 2:55 ` Tejun Heo
2009-02-02 17:12 ` [PATCH] libata: change drive ready wait after hard reset to 5s Stuart_Hayes
2009-02-02 17:12 ` Stuart_Hayes
2009-02-02 17:17 ` Mario Limonciello
2009-02-09 21:48 ` Stuart_Hayes
2009-02-09 21:48 ` Stuart_Hayes
2009-02-01 2:59 ` [PATCHSET] dmraid: use alt_size Tejun Heo
2009-02-01 2:59 ` Tejun Heo
2009-02-01 3:00 ` [PATCH 1/3] dmraid: set read_info to @offset by default in read_raid_dev() Tejun Heo
2009-02-01 3:00 ` Tejun Heo
2009-02-01 3:00 ` [PATCH 2/3] dmraid: add alt_size to dev_info Tejun Heo
2009-02-01 3:00 ` Tejun Heo
2009-02-01 3:01 ` Tejun Heo [this message]
2009-02-01 3:01 ` [PATCH 3/3] dmraid: make nv use alt_size if available Tejun Heo
2009-02-01 2:59 ` [PATCHSET] dmraid: use alt_size Tejun Heo
2009-02-01 3:20 ` [PATCHSET] block,scsi,libata: implement alt_size Jeff Garzik
2009-02-01 4:14 ` Tejun Heo
2009-02-01 4:14 ` Tejun Heo
2009-04-30 1:13 ` Tejun Heo
2009-04-30 1:13 ` Tejun Heo
2009-04-30 1:13 ` Tejun Heo
2009-04-30 1:45 ` Jeff Garzik
2009-04-30 1:50 ` Tejun Heo
2009-04-30 20:00 ` Jeff Garzik
2009-04-30 21:15 ` Dan Williams
2009-04-30 21:15 ` Dan Williams
2009-05-04 8:02 ` Tejun Heo
2009-05-04 8:02 ` Tejun Heo
2009-05-04 16:48 ` Dan Williams
2009-05-05 3:28 ` Tejun Heo
2009-05-05 15:34 ` Dan Williams
2009-05-08 9:13 ` Tejun Heo
2009-05-08 16:21 ` Jeff Garzik
2009-05-08 16:21 ` Jeff Garzik
2009-05-08 16:23 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49851070.7030306@kernel.org \
--to=tj@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=Mauelshagen@redhat.c \
--cc=dm-devel@redhat.com \
--cc=jeff@garzik.org \
--cc=jens.axboe@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.