From: Greg Ungerer <gerg@snapgear.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux/m68k <linux-m68k@vger.kernel.org>,
uClinux development list <uclinux-dev@uclinux.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] m68k: Unify arch/m68k/include/asm/unistd.h
Date: Tue, 03 Feb 2009 16:36:20 +1000 [thread overview]
Message-ID: <4987E5E4.3070409@snapgear.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0902022245400.15898@anakin>
Hi Geert,
Geert Uytterhoeven wrote:
> On Sun, 1 Feb 2009, Greg Ungerer wrote:
>> Geert Uytterhoeven wrote:
>> m68k: use mmu scatterlist.h for non-mmu setups as well
>
> A small cleanup:
Thanks, I'll put that in the git tree as well.
Regards
Greg
>>From bb3640a02d427175006f8d0c49311bf7a2290dd0 Mon Sep 17 00:00:00 2001
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Date: Mon, 2 Feb 2009 22:14:23 +0100
> Subject: [PATCH] m68k: Use dma_addr_t for scatterlist.dma_address
>
> dma_addr_t (as was used by m68knommu) is more correct than u32.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> arch/m68k/include/asm/scatterlist.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/m68k/include/asm/scatterlist.h b/arch/m68k/include/asm/scatterlist.h
> index d3a7a0e..e27ad90 100644
> --- a/arch/m68k/include/asm/scatterlist.h
> +++ b/arch/m68k/include/asm/scatterlist.h
> @@ -11,7 +11,7 @@ struct scatterlist {
> unsigned int offset;
> unsigned int length;
>
> - __u32 dma_address; /* A place to hang host-specific addresses at. */
> + dma_addr_t dma_address; /* A place to hang host-specific addresses at. */
> };
>
> /* This is bogus and should go away. */
--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear, a McAfee Company PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev
WARNING: multiple messages have this Message-ID (diff)
From: Greg Ungerer <gerg@snapgear.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: uClinux development list <uclinux-dev@uclinux.org>,
Sam Ravnborg <sam@ravnborg.org>,
Linux/m68k <linux-m68k@vger.kernel.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [uClinux-dev] [PATCH] m68k: Unify arch/m68k/include/asm/unistd.h
Date: Tue, 03 Feb 2009 16:36:20 +1000 [thread overview]
Message-ID: <4987E5E4.3070409@snapgear.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0902022245400.15898@anakin>
Hi Geert,
Geert Uytterhoeven wrote:
> On Sun, 1 Feb 2009, Greg Ungerer wrote:
>> Geert Uytterhoeven wrote:
>> m68k: use mmu scatterlist.h for non-mmu setups as well
>
> A small cleanup:
Thanks, I'll put that in the git tree as well.
Regards
Greg
>>From bb3640a02d427175006f8d0c49311bf7a2290dd0 Mon Sep 17 00:00:00 2001
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Date: Mon, 2 Feb 2009 22:14:23 +0100
> Subject: [PATCH] m68k: Use dma_addr_t for scatterlist.dma_address
>
> dma_addr_t (as was used by m68knommu) is more correct than u32.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> arch/m68k/include/asm/scatterlist.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/m68k/include/asm/scatterlist.h b/arch/m68k/include/asm/scatterlist.h
> index d3a7a0e..e27ad90 100644
> --- a/arch/m68k/include/asm/scatterlist.h
> +++ b/arch/m68k/include/asm/scatterlist.h
> @@ -11,7 +11,7 @@ struct scatterlist {
> unsigned int offset;
> unsigned int length;
>
> - __u32 dma_address; /* A place to hang host-specific addresses at. */
> + dma_addr_t dma_address; /* A place to hang host-specific addresses at. */
> };
>
> /* This is bogus and should go away. */
--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear, a McAfee Company PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com
next prev parent reply other threads:[~2009-02-03 6:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-01 10:15 [PATCH] m68k: Unify arch/m68k/include/asm/unistd.h Geert Uytterhoeven
2009-02-01 12:46 ` [uClinux-dev] " Greg Ungerer
2009-02-01 22:39 ` Sam Ravnborg
2009-02-02 21:46 ` Geert Uytterhoeven
2009-02-03 6:36 ` Greg Ungerer [this message]
2009-02-03 6:36 ` Greg Ungerer
2009-02-02 21:47 ` Geert Uytterhoeven
2009-02-02 21:47 ` [uClinux-dev] " Geert Uytterhoeven
2009-02-03 6:41 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4987E5E4.3070409@snapgear.com \
--to=gerg@snapgear.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.