BUG: LDP - smc911x region too small

BUG: LDP - smc911x region too small

[Russell King - ARM Linux]

At the moment:

        ldp_smc911x_resources[0].start = cs_mem_base + 0x0;
        ldp_smc911x_resources[0].end   = cs_mem_base + 0xf;

However, the SMC911x driver wants to claim 256 bytes from this region.
Indeed, its register set definitions appears to indicate that its needs
more than 16 bytes of address space.

So, the question is what is the right fix?

Unfortunately, fixing this will cause problems with the SMSC911x patches,
so I'd like to get an answer on this sooner rather than later please.

Re: BUG: LDP - smc911x region too small

[stanley.miao]

On Mon, 2009-01-19 at 22:37 +0000, Russell King - ARM Linux wrote:
> At the moment:
> 
>         ldp_smc911x_resources[0].start = cs_mem_base + 0x0;
>         ldp_smc911x_resources[0].end   = cs_mem_base + 0xf;
> 
> However, the SMC911x driver wants to claim 256 bytes from this region.
> Indeed, its register set definitions appears to indicate that its needs
> more than 16 bytes of address space.
> 
> So, the question is what is the right fix?
> 
> Unfortunately, fixing this will cause problems with the SMSC911x patches,
> so I'd like to get an answer on this sooner rather than later please.

Here should be 0x100. Fixing this won't cause problems with smsc911x
patches.

Stanley.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: BUG: LDP - smc911x region too small

[Russell King - ARM Linux]

On Tue, Jan 20, 2009 at 02:36:43PM +0800, stanley.miao wrote:
> On Mon, 2009-01-19 at 22:37 +0000, Russell King - ARM Linux wrote:
> > At the moment:
> > 
> >         ldp_smc911x_resources[0].start = cs_mem_base + 0x0;
> >         ldp_smc911x_resources[0].end   = cs_mem_base + 0xf;
> > 
> > However, the SMC911x driver wants to claim 256 bytes from this region.
> > Indeed, its register set definitions appears to indicate that its needs
> > more than 16 bytes of address space.
> > 
> > So, the question is what is the right fix?
> > 
> > Unfortunately, fixing this will cause problems with the SMSC911x patches,
> > so I'd like to get an answer on this sooner rather than later please.
> 
> Here should be 0x100. Fixing this won't cause problems with smsc911x
> patches.

Yes it will - if it gets fixed in the -rc series for the smc911x driver
your patches will conflict.

There's more which needs fixing though - no platform data is being passed
so the smc911x driver still fails to initialise.

RE: BUG: LDP - smc911x region too small

[Woodruff, Richard]

> > Here should be 0x100. Fixing this won't cause problems with smsc911x
> > patches.
>
> Yes it will - if it gets fixed in the -rc series for the smc911x driver
> your patches will conflict.
>
> There's more which needs fixing though - no platform data is being passed
> so the smc911x driver still fails to initialise.

Data sheet shows addressable range as 0x50 from base --> 0xFC.  So 0xFF should be good.

I tried to send Russell data sheet but his emails is rejecting it.

Regards,
Richard W.

Re: BUG: LDP - smc911x region too small

[Russell King - ARM Linux]

On Tue, Feb 03, 2009 at 05:01:26PM +0800, stanley.miao wrote:
> Woodruff, Richard wrote:
> >>>Here should be 0x100. Fixing this won't cause problems with smsc911x
> >>>patches.
> >>>      
> >>Yes it will - if it gets fixed in the -rc series for the smc911x driver
> >>your patches will conflict.
> >>
> >>There's more which needs fixing though - no platform data is being passed
> >>so the smc911x driver still fails to initialise.
> >>    
> >
> >Data sheet shows addressable range as 0x50 from base --> 0xFC.  So 0xFF 
> >should be good.
> >
> >I tried to send Russell data sheet but his emails is rejecting it.
> >
> >Regards,
> >Richard W.
> >
> >  
> It has been fixed.

No, it has not been fixed - it continues to fail in mainline kernels.

> http://marc.info/?l=linux-arm-kernel&m=123307584619895&w=2

That is a proposed patch for switching to the SMSC driver instead of
the SMC driver.  It's unclear at the moment whether it's acceptable
to switch to the SMSC driver for the -rc kernels.  Certainly just
applying the patch above results in something which is also nonfunctional.

The motivation here is to _fix_ mainline kernels.

Re: BUG: LDP - smc911x region too small

[stanley.miao]

Woodruff, Richard wrote:
>>> Here should be 0x100. Fixing this won't cause problems with smsc911x
>>> patches.
>>>       
>> Yes it will - if it gets fixed in the -rc series for the smc911x driver
>> your patches will conflict.
>>
>> There's more which needs fixing though - no platform data is being passed
>> so the smc911x driver still fails to initialise.
>>     
>
> Data sheet shows addressable range as 0x50 from base --> 0xFC.  So 0xFF should be good.
>
> I tried to send Russell data sheet but his emails is rejecting it.
>
> Regards,
> Richard W.
>
>   
It has been fixed.

http://marc.info/?l=linux-arm-kernel&m=123307584619895&w=2


Stanley.