From: Derek Ou <derek@siconix.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] lcd_putc bug?
Date: Tue, 03 Feb 2009 11:44:06 -0700 [thread overview]
Message-ID: <49889076.5010509@siconix.com> (raw)
In the lcd_putc() of common/lcd.c, line 189 handles tab '\t'. And the
following lines:
console_col |= 8;
console_col &= ~7;
seems to have problems. If console_col is 9, it will become 8 after the
above two lines, which means instead of tab of 8 spaces, it goes back
1. Is this intentional or a bug?
I think it should be console_col += 8; instead of console_col |= 8;
Derek
next reply other threads:[~2009-02-03 18:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 18:44 Derek Ou [this message]
2009-02-03 19:23 ` [U-Boot] lcd_putc bug? Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49889076.5010509@siconix.com \
--to=derek@siconix.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.