All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: balbir@linux.vnet.ibm.com
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [-mm patch] Show memcg information during OOM (v3)
Date: Wed, 04 Feb 2009 14:48:58 +0800	[thread overview]
Message-ID: <49893A5A.7000506@cn.fujitsu.com> (raw)
In-Reply-To: <20090204064249.GC4456@balbir.in.ibm.com>

>> BTW, I wonder can't we show the path of mount point ?
>> /group_A/01 is /cgroup/group_A/01 and /group_A/ is /cgroup/group_A/ on this system.
>> Very difficult ?
>>
> 
> No, it is not very difficult, we just need to append the mount point.
> The reason for not doing it is consistency with output of
> /proc/<pid>/cgroup and other places where cgroup_path prints the path
> relative to the mount point. Since we are talking about memory, the
> administrator should know where it is mounted. Do you strongly feel
> the need to add mount point? My concern is consistency with other
> cgroup output (look at /proc/sched_debug) for example.
> 

Another reason to not do so is, we can mount a specific hierarchy to
multiple mount points.
	# mount -t cgroup -o memory /mnt
	# mount -t cgroup -o memory /cgroup
	# mkdir /mnt/0
Now, /mnt/0 is the same with /cgroup/0.


WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizf@cn.fujitsu.com>
To: balbir@linux.vnet.ibm.com
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [-mm patch] Show memcg information during OOM (v3)
Date: Wed, 04 Feb 2009 14:48:58 +0800	[thread overview]
Message-ID: <49893A5A.7000506@cn.fujitsu.com> (raw)
In-Reply-To: <20090204064249.GC4456@balbir.in.ibm.com>

>> BTW, I wonder can't we show the path of mount point ?
>> /group_A/01 is /cgroup/group_A/01 and /group_A/ is /cgroup/group_A/ on this system.
>> Very difficult ?
>>
> 
> No, it is not very difficult, we just need to append the mount point.
> The reason for not doing it is consistency with output of
> /proc/<pid>/cgroup and other places where cgroup_path prints the path
> relative to the mount point. Since we are talking about memory, the
> administrator should know where it is mounted. Do you strongly feel
> the need to add mount point? My concern is consistency with other
> cgroup output (look at /proc/sched_debug) for example.
> 

Another reason to not do so is, we can mount a specific hierarchy to
multiple mount points.
	# mount -t cgroup -o memory /mnt
	# mount -t cgroup -o memory /cgroup
	# mkdir /mnt/0
Now, /mnt/0 is the same with /cgroup/0.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-02-04  6:49 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-03 17:21 [-mm patch] Show memcg information during OOM (v3) Balbir Singh
2009-02-03 17:21 ` Balbir Singh
2009-02-03 22:46 ` Andrew Morton
2009-02-03 22:46   ` Andrew Morton
2009-02-04  3:36   ` Balbir Singh
2009-02-04  3:36     ` Balbir Singh
2009-02-05 21:55   ` Andrew Morton
2009-02-05 21:55     ` Andrew Morton
2009-02-06  2:26     ` Balbir Singh
2009-02-06  2:26       ` Balbir Singh
2009-02-06  7:01     ` Balbir Singh
2009-02-06  7:01       ` Balbir Singh
2009-02-04  0:53 ` Li Zefan
2009-02-04  0:53   ` Li Zefan
2009-02-04  1:35   ` Li Zefan
2009-02-04  1:35     ` Li Zefan
2009-02-04  3:37   ` Balbir Singh
2009-02-04  3:37     ` Balbir Singh
2009-02-04  5:24     ` KAMEZAWA Hiroyuki
2009-02-04  5:24       ` KAMEZAWA Hiroyuki
2009-02-04  6:42       ` Balbir Singh
2009-02-04  6:42         ` Balbir Singh
2009-02-04  6:48         ` Li Zefan [this message]
2009-02-04  6:48           ` Li Zefan
2009-02-04  6:52           ` KAMEZAWA Hiroyuki
2009-02-04  6:52             ` KAMEZAWA Hiroyuki
2009-02-04  6:50         ` KAMEZAWA Hiroyuki
2009-02-04  6:50           ` KAMEZAWA Hiroyuki
2009-02-05  4:00 ` Lai Jiangshan
2009-02-05  4:00   ` Lai Jiangshan
2009-02-05  4:55   ` KAMEZAWA Hiroyuki
2009-02-05  4:55     ` KAMEZAWA Hiroyuki
2009-02-06  3:02 ` Li Zefan
2009-02-06  3:02   ` Li Zefan
2009-02-06  3:10   ` Li Zefan
2009-02-06  3:10     ` Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49893A5A.7000506@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nishimura@mxp.nes.nec.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.