From: Scott Wood <scottwood@freescale.com>
To: Julia Lawall <julia@diku.dk>
Cc: linuxppc-dev@ozlabs.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch/powerpc: Eliminate double sizeof
Date: Wed, 04 Feb 2009 22:13:41 +0000 [thread overview]
Message-ID: <498A1315.5060200@freescale.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0902042236200.3091@ask.diku.dk>
Julia Lawall wrote:
> Signed-off-by: Julia Lawall <julia@diku.dk>
> ---
> arch/powerpc/platforms/82xx/pq2ads-pci-pic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -u -p a/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c b/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c
> --- a/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c
> +++ b/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c
> @@ -186,7 +186,7 @@ out_unmap_regs:
> iounmap(priv->regs);
> out_free_bootmem:
> free_bootmem((unsigned long)priv,
> - sizeof(sizeof(struct pq2ads_pci_pic)));
> + sizeof(struct pq2ads_pci_pic));
> of_node_put(np);
> out_unmap_irq:
> irq_dispose_mapping(irq);
ACK
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Julia Lawall <julia@diku.dk>
Cc: linuxppc-dev@ozlabs.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch/powerpc: Eliminate double sizeof
Date: Wed, 04 Feb 2009 16:13:41 -0600 [thread overview]
Message-ID: <498A1315.5060200@freescale.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0902042236200.3091@ask.diku.dk>
Julia Lawall wrote:
> Signed-off-by: Julia Lawall <julia@diku.dk>
> ---
> arch/powerpc/platforms/82xx/pq2ads-pci-pic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -u -p a/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c b/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c
> --- a/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c
> +++ b/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c
> @@ -186,7 +186,7 @@ out_unmap_regs:
> iounmap(priv->regs);
> out_free_bootmem:
> free_bootmem((unsigned long)priv,
> - sizeof(sizeof(struct pq2ads_pci_pic)));
> + sizeof(struct pq2ads_pci_pic));
> of_node_put(np);
> out_unmap_irq:
> irq_dispose_mapping(irq);
ACK
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Julia Lawall <julia@diku.dk>
Cc: galak@kernel.crashing.org, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] arch/powerpc: Eliminate double sizeof
Date: Wed, 04 Feb 2009 16:13:41 -0600 [thread overview]
Message-ID: <498A1315.5060200@freescale.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0902042236200.3091@ask.diku.dk>
Julia Lawall wrote:
> Signed-off-by: Julia Lawall <julia@diku.dk>
> ---
> arch/powerpc/platforms/82xx/pq2ads-pci-pic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -u -p a/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c b/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c
> --- a/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c
> +++ b/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c
> @@ -186,7 +186,7 @@ out_unmap_regs:
> iounmap(priv->regs);
> out_free_bootmem:
> free_bootmem((unsigned long)priv,
> - sizeof(sizeof(struct pq2ads_pci_pic)));
> + sizeof(struct pq2ads_pci_pic));
> of_node_put(np);
> out_unmap_irq:
> irq_dispose_mapping(irq);
ACK
-Scott
next prev parent reply other threads:[~2009-02-04 22:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 21:43 [PATCH] arch/powerpc: Eliminate double sizeof Julia Lawall
2009-02-04 21:43 ` Julia Lawall
2009-02-04 22:13 ` Scott Wood [this message]
2009-02-04 22:13 ` Scott Wood
2009-02-04 22:13 ` Scott Wood
2009-02-06 16:44 ` Kumar Gala
2009-02-06 16:44 ` Kumar Gala
2009-02-06 16:44 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498A1315.5060200@freescale.com \
--to=scottwood@freescale.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.