All of lore.kernel.org
 help / color / mirror / Atom feed
From: phcoder <phcoder@gmail.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: [Bugfix] vbetest doesn't return to text mode
Date: Thu, 05 Feb 2009 18:56:32 +0100	[thread overview]
Message-ID: <498B2850.1090008@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

Hello. In text mode bits_per_pixel isn't set. Because of it 
grub_vbe_set_video_mode refuses to go back to text mode after vbetest 
command. Here is a bugfix
Thanks
Vladimir 'phcoder' Serbinenko

[-- Attachment #2: vbefix.diff --]
[-- Type: text/x-diff, Size: 985 bytes --]

Index: video/i386/pc/vbe.c
===================================================================
--- video/i386/pc/vbe.c	(revision 1973)
+++ video/i386/pc/vbe.c	(working copy)
@@ -215,6 +215,8 @@
     case 15: framebuffer.bytes_per_pixel = 2; break;
     case 8: framebuffer.bytes_per_pixel = 1; break;
     default:
+      if (mode <= 3 || mode ==  7)
+	break; 
       grub_vbe_bios_set_mode (old_mode, 0);
       return grub_error (GRUB_ERR_BAD_DEVICE,
                          "cannot set VBE mode %x",
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 1973)
+++ ChangeLog	(working copy)
@@ -1,3 +1,10 @@
+2009-02-05  Vladimir Serbinenko  <phcoder@gmail.com>
+
+	Don't check bits_per_pixel in text mode
+
+	* video/i386/pc/vbe.c (grub_vbe_set_video_mode): Don't check 
+	bits_per_pixel in text mode
+
 2009-02-04  Felix Zielcke  <fzielcke@z-51.de>
 
 	util/getroot.c (grub_util_get_grub_dev): Add support for /dev/mdNpN and

             reply	other threads:[~2009-02-05 17:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-05 17:56 phcoder [this message]
2009-02-05 18:30 ` [Bugfix] vbetest doesn't return to text mode Vesa Jääskeläinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=498B2850.1090008@gmail.com \
    --to=phcoder@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.