* [PATCH JGIT] New PersonIdent of a repository is the default committer
@ 2009-02-06 16:04 Yann Simon
0 siblings, 0 replies; only message in thread
From: Yann Simon @ 2009-02-06 16:04 UTC (permalink / raw)
To: Robin Rosenberg, Shawn O. Pearce; +Cc: git
The constructor PersonIdent(Repository) uses the default values
from the configuration of the repository.
The new instance gets the name and the email of the default committer.
Signed-off-by: Yann Simon <yann.simon.fr@gmail.com>
---
.../src/org/spearce/jgit/lib/PersonIdent.java | 26 ++++----------------
1 files changed, 5 insertions(+), 21 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/PersonIdent.java b/org.spearce.jgit/src/org/spearce/jgit/lib/PersonIdent.java
index bc5479a..fb4ab20 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/PersonIdent.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/PersonIdent.java
@@ -57,33 +57,17 @@
private final int tzOffset;
- private static String getHostName() {
- try {
- java.net.InetAddress addr = java.net.InetAddress.getLocalHost();
- String hostname = addr.getCanonicalHostName();
- return hostname;
- } catch (java.net.UnknownHostException e) {
- return "localhost";
- }
- }
-
/**
- * Creates new PersonIdent from config info in repository, with current time
+ * Creates new PersonIdent from config info in repository, with current time.
+ * This new PersonIdent gets the info from the default committer as available
+ * from the configuration.
*
* @param repo
*/
public PersonIdent(final Repository repo) {
RepositoryConfig config = repo.getConfig();
- String username = config.getString("user", null, "name");
- if (username == null)
- username = System.getProperty("user.name");
-
- String email = config.getString("user", null, "email");
- if (email == null)
- email = System.getProperty("user.name") + "@" + getHostName();
-
- name = username;
- emailAddress = email;
+ name = config.getCommitterName();
+ emailAddress = config.getCommitterEmail();
when = System.currentTimeMillis();
tzOffset = TimeZone.getDefault().getOffset(when) / (60 * 1000);
}
--
1.6.0.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-02-06 16:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-06 16:04 [PATCH JGIT] New PersonIdent of a repository is the default committer Yann Simon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.