From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Stanislaw Gruszka <stf_xl@wp.pl>
Cc: linux-ide@vger.kernel.org, Andrew Victor <avictor.za@gmail.com>,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH 3/3 v2] AT91: initialize Compact Flash on AT91SAM9263 cpu
Date: Fri, 06 Feb 2009 20:23:55 +0300 [thread overview]
Message-ID: <498C722B.6060808@ru.mvista.com> (raw)
In-Reply-To: <200902061433.19490.stf_xl@wp.pl>
Stanislaw Gruszka wrote:
>>>+void __init at91_add_device_cf(struct at91_cf_data *data)
>>>+{
>>[...]
>>>+ /* enable EBI controlled pins */
>>>+ at91_set_A_periph(AT91_PIN_PD5, 1); /* NWAIT */
>>>+ at91_set_A_periph(AT91_PIN_PD8, 0); /* CFCE1 */
>>>+ at91_set_A_periph(AT91_PIN_PD9, 0); /* CFCE2 */
>>>+ at91_set_A_periph(AT91_PIN_PD14, 0); /* CFNRW */
>>>+
>>>+ if (data->flags & AT91_CF_TRUE_IDE)
>> Again, I've probably missed something but this structre doesn't have
>>the 'flags' field. How is this suppoed to compile?
> Patch 2/3 add flags to the at91_cf_data structure.
Ah, stupid me. Haven't looked at that patch yet. :-<
> Stanislaw Gruszka
MBR, Sergei
prev parent reply other threads:[~2009-02-06 17:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 11:14 [PATCH 3/3 v2] AT91: initialize Compact Flash on AT91SAM9263 cpu Stanislaw Gruszka
2009-02-06 12:03 ` Sergei Shtylyov
2009-02-06 13:32 ` Stanislaw Gruszka
2009-02-15 16:00 ` Sergei Shtylyov
2009-02-15 16:07 ` Sergei Shtylyov
2009-02-06 12:17 ` Sergei Shtylyov
2009-02-06 13:33 ` Stanislaw Gruszka
2009-02-06 17:23 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498C722B.6060808@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=avictor.za@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=stf_xl@wp.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.