Re: [PATCH 3/3 v2] AT91: initialize Compact Flash on AT91SAM9263 cpu

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello, I wrote:

>>>> +    if (data->det_pin) {
>>>> +        /* check if device is present */
>>>> +        at91_set_gpio_input(data->det_pin, 1);
>>>> +        at91_set_deglitch(data->det_pin, 1);
>>>> +        if (at91_get_gpio_value(data->det_pin) != 0) {
>>>> +            printk(KERN_ERR "AT91: no CF card detected\n");
>>>> +            return;
>>>> +        }
>>>> +    }

>>>   Bart, I'm not sure: don't we support warm-plug now? Or it won't 
>>> avail us with CF?

>> Uhh, this code is wrong at least for PCMCIA as we hotplug there. I 
>> don't think
>> hotplug is supported for ATA devices.

>    I didn't say hot plug, I said *warm* plug. You can force port probing 
> via sysfs, if I don't mistake... Bart?

    See Documentation/ide/warm-plug-howto.txt

MBR, Sergei