All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>, Beth Kon <eak@us.ibm.com>,
	Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [RFC][PATCH] disable special ioapic inti0 routing
Date: Fri, 06 Feb 2009 17:51:08 -0600	[thread overview]
Message-ID: <498CCCEC.4050205@codemonkey.ws> (raw)
In-Reply-To: <498CC81B.2070407@web.de>

Jan Kiszka wrote:
> This patch comes from the kvm tree and fixes the timer IRQ routing for
> me which is broken from the POV of certain Linux guest kernels. As I'm
> not up-to-date with the development around that problematic hunk, I'm
> leaving it to someone more deeply involved to sign this off. But please
> commit some fix.
>   

Are you using an old bios by chance?  The reason this fixes KVM has 
nothing to do with QEMU FWIW so if this fixes something for you, it's 
just a coincidence.

Regards,

Anthony Liguroi

> Thanks,
> Jan
>
> ------->
>
> From: Avi Kivity <avi@redhat.com>
>
> we don't support it yet (need bios support, and modifications to kernel
> irq routing).
>
> ---
>  qemu/hw/apic.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/qemu/hw/apic.c b/qemu/hw/apic.c
> index df80444..f9ef995 100644
> --- a/qemu/hw/apic.c
> +++ b/qemu/hw/apic.c
> @@ -1055,12 +1055,14 @@ void ioapic_set_irq(void *opaque, int vector, int level)
>  {
>      IOAPICState *s = opaque;
>  
> +#if 0
>      /* ISA IRQs map to GSI 1-1 except for IRQ0 which maps
>       * to GSI 2.  GSI maps to ioapic 1-1.  This is not
>       * the cleanest way of doing it but it should work. */
>  
>      if (vector == 0)
>          vector = 2;
> +#endif
>  
>      if (vector >= 0 && vector < IOAPIC_NUM_PINS) {
>          uint32_t mask = 1 << vector;
>
>
>
>   

  reply	other threads:[~2009-02-06 23:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-06 23:30 [Qemu-devel] [RFC][PATCH] disable special ioapic inti0 routing Jan Kiszka
2009-02-06 23:51 ` Anthony Liguori [this message]
2009-02-07  0:07   ` [Qemu-devel] " Jan Kiszka
2009-02-07  1:30     ` Anthony Liguori
2009-02-07  2:09       ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=498CCCEC.4050205@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=eak@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.