All of lore.kernel.org
 help / color / mirror / Atom feed
From: phcoder <phcoder@gmail.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: [Bugfix] Characters disappearing in gfxterm
Date: Sun, 08 Feb 2009 00:14:24 +0100	[thread overview]
Message-ID: <498E15D0.4090101@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

Hello. I've run into the bug that when editing menu entry in gfxterm 
characters disappear after cursor moves away from its position. Here is 
bugfix

Thanks
Vladimir 'phcoder' Serbinenko

[-- Attachment #2: cursorfix --]
[-- Type: text/plain, Size: 1232 bytes --]

Index: term/gfxterm.c
===================================================================
--- term/gfxterm.c	(revision 1974)
+++ term/gfxterm.c	(working copy)
@@ -744,6 +744,8 @@
   /* Render cursor to text layer.  */
   grub_video_set_active_render_target (text_layer);
   grub_video_fill_rect (color, x, y, width, height);
+  if (! show)
+    write_char ();
   grub_video_set_active_render_target (GRUB_VIDEO_RENDER_TARGET_DISPLAY);
 
   /* Mark cursor to be redrawn.  */
@@ -1176,6 +1178,6 @@
 
 GRUB_MOD_FINI(term_gfxterm)
 {
-  grub_unregister_command ("bgimage");
+  grub_unregister_command ("background_image");
   grub_term_unregister_output (&grub_video_term);
 }
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 1974)
+++ ChangeLog	(working copy)
@@ -1,3 +1,24 @@
+2009-02-07  Vladimir Serbinenko  <phcoder@gmail.com>
+
+	Redraw character so it doesn't disappear after cursor moves from it
+
+	* term/gfterm.c (draw_cursor): Redraw character so it 
+	doesn't disappear after cursor moves from it
+	(GRUB_MOD_FINI): correct the name of the command
+
 2009-02-05  Vesa Jääskeläinen  <chaac@nic.fi>
 
 	Fixes problem when running vbetest command as reported by 

             reply	other threads:[~2009-02-07 23:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-07 23:14 phcoder [this message]
2009-02-08  8:47 ` [Bugfix] Characters disappearing in gfxterm Vesa Jääskeläinen
2009-02-10  2:04   ` BandiPat
2009-02-10 16:12     ` Vesa Jääskeläinen
2009-03-11 14:36   ` BandiPat
2009-03-11 21:10     ` Robert Millan
2009-03-12 13:34       ` BandiPat
2009-03-12 19:08   ` [Bugfix] Characters disappearing in gfxterm [fix committed] Colin D Bennett
2009-03-16  1:27     ` BandiPat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=498E15D0.4090101@gmail.com \
    --to=phcoder@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.