All of lore.kernel.org
 help / color / mirror / Atom feed
From: BandiPat <magicpage91@earthlink.net>
To: GRUB 2 <grub-devel@gnu.org>
Subject: Re: [Bugfix] Characters disappearing in gfxterm
Date: Wed, 11 Mar 2009 10:36:40 -0400	[thread overview]
Message-ID: <49B7CC78.405@earthlink.net> (raw)
In-Reply-To: <498E9C26.40407@nic.fi>

Vesa Jääskeläinen wrote:
> phcoder wrote:
>> Hello. I've run into the bug that when editing menu entry in gfxterm
>> characters disappear after cursor moves away from its position. Here is
>> bugfix
> 
> I don't think this is a clean fix:
> 
>> Index: term/gfxterm.c
>> ===================================================================
>> --- term/gfxterm.c	(revision 1974)
>> +++ term/gfxterm.c	(working copy)
>> @@ -744,6 +744,8 @@
>>    /* Render cursor to text layer.  */
>>    grub_video_set_active_render_target (text_layer);
>>    grub_video_fill_rect (color, x, y, width, height);
>> +  if (! show)
>> +    write_char ();
>>    grub_video_set_active_render_target (GRUB_VIDEO_RENDER_TARGET_DISPLAY);
>>  
>>    /* Mark cursor to be redrawn.  */
> 
> It is not designed to work in there. I think modifying this needs
> logical level approach and not ad hoc fix.
=====================

Has there been any further work done on the disappearing characters in 
gfxterm?  I know you guys had looked at it, but the last word was it was 
not fixed yet.  I understand it's not a priority, but a fix would help 
in me getting the devs for Zenwalk to approve it's use in the next 
release version.

Also, do you intend to release another stable version soon?  As I watch 
the progress of Grub2, I continue to see a good program get even better, 
so using svn is fine for me!  You've added so much since the 1.96 
release though, it just seems another stable release is past due. 
Continue the great work you're doing though, as good software never 
truly gets finished!

Thanks,
Pat


-- 
        ---Zenwalk v6.0--Linux 2.6.28---
         Registered Linux User #225206
"Ever tried Zen computing?"  http://www.zenwalk.org






  parent reply	other threads:[~2009-03-11 14:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-07 23:14 [Bugfix] Characters disappearing in gfxterm phcoder
2009-02-08  8:47 ` Vesa Jääskeläinen
2009-02-10  2:04   ` BandiPat
2009-02-10 16:12     ` Vesa Jääskeläinen
2009-03-11 14:36   ` BandiPat [this message]
2009-03-11 21:10     ` Robert Millan
2009-03-12 13:34       ` BandiPat
2009-03-12 19:08   ` [Bugfix] Characters disappearing in gfxterm [fix committed] Colin D Bennett
2009-03-16  1:27     ` BandiPat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49B7CC78.405@earthlink.net \
    --to=magicpage91@earthlink.net \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.