* [PATCH] ASoC: count reaches 10001, not 10000.
@ 2009-02-08 17:17 Roel Kluin
2009-02-08 17:45 ` Bryan Wu
2009-02-08 20:36 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Roel Kluin @ 2009-02-08 17:17 UTC (permalink / raw)
To: lrg, cooloney, Mark Brown; +Cc: uclinux-dist-devel, alsa-devel
With a postfix increment count reaches 10001, not 10000.
diff --git a/sound/soc/blackfin/bf5xx-ad73311.c b/sound/soc/blackfin/bf5xx-ad73311.c
index 7f2a5e1..edfbdc0 100644
--- a/sound/soc/blackfin/bf5xx-ad73311.c
+++ b/sound/soc/blackfin/bf5xx-ad73311.c
@@ -114,7 +114,7 @@ static int snd_ad73311_configure(void)
SSYNC();
/* When TUVF is set, the data is already send out */
- while (!(status & TUVF) && count++ < 10000) {
+ while (!(status & TUVF) && ++count < 10000) {
udelay(1);
status = bfin_read_SPORT_STAT();
SSYNC();
@@ -123,7 +123,7 @@ static int snd_ad73311_configure(void)
SSYNC();
local_irq_enable();
- if (count == 10000) {
+ if (count >= 10000) {
printk(KERN_ERR "ad73311: failed to configure codec\n");
return -1;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: count reaches 10001, not 10000.
2009-02-08 17:17 [PATCH] ASoC: count reaches 10001, not 10000 Roel Kluin
@ 2009-02-08 17:45 ` Bryan Wu
2009-02-08 20:36 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Bryan Wu @ 2009-02-08 17:45 UTC (permalink / raw)
To: Roel Kluin, Cliff Cai; +Cc: uclinux-dist-devel, alsa-devel, Mark Brown, lrg
On Mon, Feb 9, 2009 at 1:17 AM, Roel Kluin <roel.kluin@gmail.com> wrote:
> With a postfix increment count reaches 10001, not 10000.
>
Thanks a lot, it looks fine for me. Add Cliff to this email, since he
is maintaining this driver.
-Bryan
> diff --git a/sound/soc/blackfin/bf5xx-ad73311.c b/sound/soc/blackfin/bf5xx-ad73311.c
> index 7f2a5e1..edfbdc0 100644
> --- a/sound/soc/blackfin/bf5xx-ad73311.c
> +++ b/sound/soc/blackfin/bf5xx-ad73311.c
> @@ -114,7 +114,7 @@ static int snd_ad73311_configure(void)
> SSYNC();
>
> /* When TUVF is set, the data is already send out */
> - while (!(status & TUVF) && count++ < 10000) {
> + while (!(status & TUVF) && ++count < 10000) {
> udelay(1);
> status = bfin_read_SPORT_STAT();
> SSYNC();
> @@ -123,7 +123,7 @@ static int snd_ad73311_configure(void)
> SSYNC();
> local_irq_enable();
>
> - if (count == 10000) {
> + if (count >= 10000) {
> printk(KERN_ERR "ad73311: failed to configure codec\n");
> return -1;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: count reaches 10001, not 10000.
2009-02-08 17:17 [PATCH] ASoC: count reaches 10001, not 10000 Roel Kluin
2009-02-08 17:45 ` Bryan Wu
@ 2009-02-08 20:36 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2009-02-08 20:36 UTC (permalink / raw)
To: Roel Kluin; +Cc: uclinux-dist-devel, cooloney, alsa-devel, lrg
On Sun, Feb 08, 2009 at 06:17:37PM +0100, Roel Kluin wrote:
> With a postfix increment count reaches 10001, not 10000.
Applied since it's very small but please try to remember to provide a
signed-off-by for your commits.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-02-08 20:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-08 17:17 [PATCH] ASoC: count reaches 10001, not 10000 Roel Kluin
2009-02-08 17:45 ` Bryan Wu
2009-02-08 20:36 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.