[PATCH] newport: newport_*wait() return 0 on timeout

[PATCH] newport: newport_*wait() return 0 on timeout

[Roel Kluin]

With a postfix decrement t reaches -1 on timeout which results in a
return of 0.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/include/video/newport.h b/include/video/newport.h
index 1f5ebea..001b935 100644
--- a/include/video/newport.h
+++ b/include/video/newport.h
@@ -453,7 +453,7 @@ static __inline__ int newport_wait(struct newport_regs *regs)
 {
 	int t = BUSY_TIMEOUT;
 
-	while (t--)
+	while (--t)
 		if (!(regs->cset.status & NPORT_STAT_GBUSY))
 			break;
 	return !t;
@@ -463,7 +463,7 @@ static __inline__ int newport_bfwait(struct newport_regs *regs)
 {
 	int t = BUSY_TIMEOUT;
 
-	while (t--)
+	while (--t)
 		if(!(regs->cset.status & NPORT_STAT_BBUSY))
 			break;
 	return !t;


------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com

[PATCH] newport: newport_*wait() return 0 on timeout

[Roel Kluin]

With a postfix decrement t reaches -1 on timeout which results in a
return of 0.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/include/video/newport.h b/include/video/newport.h
index 1f5ebea..001b935 100644
--- a/include/video/newport.h
+++ b/include/video/newport.h
@@ -453,7 +453,7 @@ static __inline__ int newport_wait(struct newport_regs *regs)
 {
 	int t = BUSY_TIMEOUT;
 
-	while (t--)
+	while (--t)
 		if (!(regs->cset.status & NPORT_STAT_GBUSY))
 			break;
 	return !t;
@@ -463,7 +463,7 @@ static __inline__ int newport_bfwait(struct newport_regs *regs)
 {
 	int t = BUSY_TIMEOUT;
 
-	while (t--)
+	while (--t)
 		if(!(regs->cset.status & NPORT_STAT_BBUSY))
 			break;
 	return !t;

Re: [PATCH] newport: newport_*wait() return 0 on timeout

[Mauro Carvalho Chehab]

Hi Roel,

It seems that you've sent this driver to the wrong ML. Video adapters are not handled on those ML's.

On Sat, 31 Jan 2009 16:29:39 +0100
Roel Kluin <roel.kluin@gmail.com> wrote:

> With a postfix decrement t reaches -1 on timeout which results in a
> return of 0.
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/include/video/newport.h b/include/video/newport.h
> index 1f5ebea..001b935 100644
> --- a/include/video/newport.h
> +++ b/include/video/newport.h
> @@ -453,7 +453,7 @@ static __inline__ int newport_wait(struct newport_regs *regs)
>  {
>  	int t = BUSY_TIMEOUT;
>  
> -	while (t--)
> +	while (--t)
>  		if (!(regs->cset.status & NPORT_STAT_GBUSY))
>  			break;
>  	return !t;
> @@ -463,7 +463,7 @@ static __inline__ int newport_bfwait(struct newport_regs *regs)
>  {
>  	int t = BUSY_TIMEOUT;
>  
> -	while (t--)
> +	while (--t)
>  		if(!(regs->cset.status & NPORT_STAT_BBUSY))
>  			break;
>  	return !t;




Cheers,
Mauro

Re: [PATCH] newport: newport_*wait() return 0 on timeout

[roel kluin]

2009/2/2 Mauro Carvalho Chehab <mchehab@infradead.org>:
> Hi Roel,
>
> It seems that you've sent this driver to the wrong ML. Video adapters are not handled on those ML's.

Any idea where it should be sent?

Thanks,

Roel

Re: [PATCH] newport: newport_*wait() return 0 on timeout

[Randy Dunlap]

roel kluin wrote:
> 2009/2/2 Mauro Carvalho Chehab <mchehab@infradead.org>:
>> Hi Roel,
>>
>> It seems that you've sent this driver to the wrong ML. Video adapters are not handled on those ML's.
> 
> Any idea where it should be sent?

drivers/video/* generally go to here AFAIK:

FRAMEBUFFER LAYER
P:	Antonino Daplas
M:	adaplas@gmail.com
L:	linux-fbdev-devel@lists.sourceforge.net (moderated for non-subscribers)
W:	http://linux-fbdev.sourceforge.net/
S:	Maintained



~Randy

Re: [PATCH] newport: newport_*wait() return 0 on timeout

[Mauro Carvalho Chehab]

On Mon, 2 Feb 2009 14:32:09 +0100
roel kluin <roel.kluin@gmail.com> wrote:

> 2009/2/2 Mauro Carvalho Chehab <mchehab@infradead.org>:
> > Hi Roel,
> >
> > It seems that you've sent this driver to the wrong ML. Video adapters are not handled on those ML's.
> 
> Any idea where it should be sent?

$ git log include/video/newport.h
commit 3f08ff4a4dab1ebef06d154050fb80ce2c13fc9c
Author: Adrian Bunk <bunk@stusta.de>
Date:   Mon Jan 9 20:53:35 2006 -0800

    [PATCH] include/video/newport.h: "extern inline" -> "static inline"
    
    "extern inline" doesn't make much sense.
    
    Signed-off-by: Adrian Bunk <bunk@stusta.de>
    Cc: "Antonino A. Daplas" <adaplas@pol.net>
    Signed-off-by: Andrew Morton <akpm@osdl.org>
    Signed-off-by: Linus Torvalds <torvalds@osdl.org>

Hmm... this is the only change on this file since -git history. I would forward the patch to Andrew.

Cheers,
Mauro