From: Clemens Ladisch <clemens@ladisch.de>
To: Pierre Ossman <drzeus@drzeus.cx>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH] i8327: fix outb() parameter order
Date: Tue, 10 Feb 2009 09:21:07 +0100 [thread overview]
Message-ID: <499138F3.9060903@ladisch.de> (raw)
In i8237A_resume(), when resetting the DMA controller, the parameters to
dma_outb() were mixed up.
Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
--- linux-2.6.orig/arch/x86/kernel/i8237.c
+++ linux-2.6/arch/x86/kernel/i8237.c
@@ -28,8 +28,8 @@ static int i8237A_resume(struct sys_devi
flags = claim_dma_lock();
- dma_outb(DMA1_RESET_REG, 0);
- dma_outb(DMA2_RESET_REG, 0);
+ dma_outb(0, DMA1_RESET_REG);
+ dma_outb(0, DMA2_RESET_REG);
for (i = 0;i < 8;i++) {
set_dma_addr(i, 0x000000);
next reply other threads:[~2009-02-10 8:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 8:21 Clemens Ladisch [this message]
2009-02-10 12:14 ` [PATCH] i8327: fix outb() parameter order Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499138F3.9060903@ladisch.de \
--to=clemens@ladisch.de \
--cc=drzeus@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.