* [PATCH] i8327: fix outb() parameter order
@ 2009-02-10 8:21 Clemens Ladisch
2009-02-10 12:14 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Clemens Ladisch @ 2009-02-10 8:21 UTC (permalink / raw)
To: Pierre Ossman; +Cc: lkml
In i8237A_resume(), when resetting the DMA controller, the parameters to
dma_outb() were mixed up.
Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
--- linux-2.6.orig/arch/x86/kernel/i8237.c
+++ linux-2.6/arch/x86/kernel/i8237.c
@@ -28,8 +28,8 @@ static int i8237A_resume(struct sys_devi
flags = claim_dma_lock();
- dma_outb(DMA1_RESET_REG, 0);
- dma_outb(DMA2_RESET_REG, 0);
+ dma_outb(0, DMA1_RESET_REG);
+ dma_outb(0, DMA2_RESET_REG);
for (i = 0;i < 8;i++) {
set_dma_addr(i, 0x000000);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] i8327: fix outb() parameter order
2009-02-10 8:21 [PATCH] i8327: fix outb() parameter order Clemens Ladisch
@ 2009-02-10 12:14 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2009-02-10 12:14 UTC (permalink / raw)
To: Clemens Ladisch; +Cc: Pierre Ossman, lkml, H. Peter Anvin, Thomas Gleixner
* Clemens Ladisch <clemens@ladisch.de> wrote:
> In i8237A_resume(), when resetting the DMA controller, the parameters to
> dma_outb() were mixed up.
>
> Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
>
> --- linux-2.6.orig/arch/x86/kernel/i8237.c
> +++ linux-2.6/arch/x86/kernel/i8237.c
> @@ -28,8 +28,8 @@ static int i8237A_resume(struct sys_devi
>
> flags = claim_dma_lock();
>
> - dma_outb(DMA1_RESET_REG, 0);
> - dma_outb(DMA2_RESET_REG, 0);
> + dma_outb(0, DMA1_RESET_REG);
> + dma_outb(0, DMA2_RESET_REG);
>
> for (i = 0;i < 8;i++) {
> set_dma_addr(i, 0x000000);
Good catch, applied to tip:x86/urgent, thanks!
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-10 12:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-10 8:21 [PATCH] i8327: fix outb() parameter order Clemens Ladisch
2009-02-10 12:14 ` Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.