From: "Sachin P. Sant" <sachinp@in.ibm.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
Mel Gorman <mel@csn.ul.ie>,
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
linuxppc-dev@ozlabs.org, Jens Axboe <jens.axboe@oracle.com>
Subject: Re: [patch] powerpc/ps3: Use hard coded values for LV1 device type
Date: Wed, 11 Feb 2009 10:58:34 +0530 [thread overview]
Message-ID: <49926202.3010405@in.ibm.com> (raw)
In-Reply-To: <1234151988.8776.4.camel@localhost.localdomain>
James Bottomley wrote:
> Actually, I think the fix lies in scsi.h ... we can make that into a
> nicely independent protocol header file. Your current woes come because
> it pulls in scsi_cmnd.h ... perhaps just getting rid of this will fix
> it.
>
> Can the rest of linux-scsi verify that the fix below doesn't break
> something else?
>
> I found one cockup: block/cmd-filter.c is apparently not including
> linuc/blkdev.h directly but via scsi/scsi.h ... I fixed this up.
>
Tested the patch and it fixes the issue.
Thanks
-Sachin
--
---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------
WARNING: multiple messages have this Message-ID (diff)
From: "Sachin P. Sant" <sachinp@in.ibm.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
Mel Gorman <mel@csn.ul.ie>,
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
linuxppc-dev@ozlabs.org, Jens Axboe <jens.axboe@oracle.com>
Subject: Re: [patch] powerpc/ps3: Use hard coded values for LV1 device type
Date: Wed, 11 Feb 2009 10:58:34 +0530 [thread overview]
Message-ID: <49926202.3010405@in.ibm.com> (raw)
In-Reply-To: <1234151988.8776.4.camel@localhost.localdomain>
James Bottomley wrote:
> Actually, I think the fix lies in scsi.h ... we can make that into a
> nicely independent protocol header file. Your current woes come because
> it pulls in scsi_cmnd.h ... perhaps just getting rid of this will fix
> it.
>
> Can the rest of linux-scsi verify that the fix below doesn't break
> something else?
>
> I found one cockup: block/cmd-filter.c is apparently not including
> linuc/blkdev.h directly but via scsi/scsi.h ... I fixed this up.
>
Tested the patch and it fixes the issue.
Thanks
-Sachin
--
---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------
next prev parent reply other threads:[~2009-02-11 5:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 16:58 2.6.29-rc3-git9 build break : arch/powerpc/platforms/ps3/setup.o Sachin P. Sant
2009-02-07 2:42 ` [patch] powerpc/ps3: Use hard coded values for LV1 device type Geoff Levand
2009-02-07 17:41 ` Sachin P. Sant
2009-02-08 11:29 ` Michael Ellerman
2009-02-09 0:11 ` Benjamin Herrenschmidt
2009-02-09 3:59 ` James Bottomley
2009-02-09 3:59 ` James Bottomley
2009-02-10 22:46 ` Geoff Levand
2009-02-10 22:46 ` Geoff Levand
2009-02-11 5:28 ` Sachin P. Sant [this message]
2009-02-11 5:28 ` Sachin P. Sant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49926202.3010405@in.ibm.com \
--to=sachinp@in.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=benh@kernel.crashing.org \
--cc=jens.axboe@oracle.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.