From: Jiri Slaby <jirislaby@gmail.com>
To: Hannes Eder <hannes@hanneseder.net>
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/isdn/hardware/mISDN: fix sparse warnings: make
Date: Fri, 13 Feb 2009 10:05:58 +0000 [thread overview]
Message-ID: <49954606.9080204@gmail.com> (raw)
In-Reply-To: <20090212192810.7401.70271.stgit@vmbox.hanneseder.net>
On 02/12/2009 08:28 PM, Hannes Eder wrote:
> diff --git a/drivers/isdn/hardware/mISDN/hfcpci.c b/drivers/isdn/hardware/mISDN/hfcpci.c
> index f0e14df..2bb85c4 100644
> --- a/drivers/isdn/hardware/mISDN/hfcpci.c
> +++ b/drivers/isdn/hardware/mISDN/hfcpci.c
> @@ -56,8 +56,8 @@ static const char *hfcpci_revision = "2.0";
> static int HFC_cnt;
> static uint debug;
> static uint poll, tics;
> -struct timer_list hfc_tl;
> -u32 hfc_jiffies;
> +static struct timer_list hfc_tl;
> +static u32 hfc_jiffies;
Please also fix the hfc_jiffies type (ulong). (As a separate patch.)
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jirislaby@gmail.com>
To: Hannes Eder <hannes@hanneseder.net>
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/isdn/hardware/mISDN: fix sparse warnings: make symbols static
Date: Fri, 13 Feb 2009 11:05:58 +0100 [thread overview]
Message-ID: <49954606.9080204@gmail.com> (raw)
In-Reply-To: <20090212192810.7401.70271.stgit@vmbox.hanneseder.net>
On 02/12/2009 08:28 PM, Hannes Eder wrote:
> diff --git a/drivers/isdn/hardware/mISDN/hfcpci.c b/drivers/isdn/hardware/mISDN/hfcpci.c
> index f0e14df..2bb85c4 100644
> --- a/drivers/isdn/hardware/mISDN/hfcpci.c
> +++ b/drivers/isdn/hardware/mISDN/hfcpci.c
> @@ -56,8 +56,8 @@ static const char *hfcpci_revision = "2.0";
> static int HFC_cnt;
> static uint debug;
> static uint poll, tics;
> -struct timer_list hfc_tl;
> -u32 hfc_jiffies;
> +static struct timer_list hfc_tl;
> +static u32 hfc_jiffies;
Please also fix the hfc_jiffies type (ulong). (As a separate patch.)
next prev parent reply other threads:[~2009-02-13 10:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 19:28 [PATCH] drivers/isdn/hardware/mISDN: fix sparse warnings: make Hannes Eder
2009-02-12 19:28 ` [PATCH] drivers/isdn/hardware/mISDN: fix sparse warnings: make symbols static Hannes Eder
2009-02-13 10:05 ` Jiri Slaby [this message]
2009-02-13 10:05 ` Jiri Slaby
2009-02-16 7:39 ` [PATCH] drivers/isdn/hardware/mISDN: fix sparse warnings: make David Miller
2009-02-16 7:39 ` [PATCH] drivers/isdn/hardware/mISDN: fix sparse warnings: make symbols static David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49954606.9080204@gmail.com \
--to=jirislaby@gmail.com \
--cc=hannes@hanneseder.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.