From: "H. Peter Anvin" <hpa@zytor.com>
To: hpa@zytor.com, mingo@redhat.com,
James.Bottomley@HansenPartnership.com, tglx@linutronix.de,
mingo@elte.hu, linux-kernel@vger.kernel.org
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/headers] x86: fix "__udivdi3" [drivers/scsi/aha1542.ko] undefined
Date: Fri, 13 Feb 2009 12:14:33 -0800 [thread overview]
Message-ID: <4995D4A9.5060400@zytor.com> (raw)
In-Reply-To: <tip-bf33a70a73876b163d62612e9567cbac6604ba7e@kernel.org>
James Bottomley wrote:
> arch/x86/include/asm/io.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/include/asm/io.h b/arch/x86/include/asm/io.h
> index e5a2ab4..4f8e820 100644
> --- a/arch/x86/include/asm/io.h
> +++ b/arch/x86/include/asm/io.h
> @@ -125,7 +125,7 @@ static inline void *phys_to_virt(phys_addr_t address)
> /*
> * ISA I/O bus memory addresses are 1:1 with the physical address.
> */
> -#define isa_virt_to_bus virt_to_phys
> +#define isa_virt_to_bus (unsigned long)virt_to_phys
> #define isa_page_to_bus page_to_phys
> #define isa_bus_to_virt phys_to_virt
>
This changes one token to multiple, and not even with the highest
precedence.
It needs to be something like:
#define isa_virt_to_bus(x) ((unsigned int)virt_to_phys(x))
... if we're going to do that.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next parent reply other threads:[~2009-02-13 20:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-bf33a70a73876b163d62612e9567cbac6604ba7e@kernel.org>
2009-02-13 20:14 ` H. Peter Anvin [this message]
2009-02-13 21:36 ` [tip:x86/headers] x86: fix "__udivdi3" [drivers/scsi/aha1542.ko] undefined James Bottomley
2009-02-13 22:51 ` H. Peter Anvin
2009-02-14 7:36 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4995D4A9.5060400@zytor.com \
--to=hpa@zytor.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.