From: "H. Peter Anvin" <hpa@zytor.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: mingo@redhat.com, tglx@linutronix.de, mingo@elte.hu,
linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/headers] x86: fix "__udivdi3" [drivers/scsi/aha1542.ko] undefined
Date: Fri, 13 Feb 2009 14:51:37 -0800 [thread overview]
Message-ID: <4995F979.9040304@zytor.com> (raw)
In-Reply-To: <1234560979.3252.22.camel@localhost.localdomain>
James Bottomley wrote:
> On Fri, 2009-02-13 at 12:14 -0800, H. Peter Anvin wrote:
>> James Bottomley wrote:
>>
>> #define isa_virt_to_bus(x) ((unsigned int)virt_to_phys(x))
>>
>> ... if we're going to do that.
>
> Actually, it probably wants to become a static inline ... that way the
> compiler can always verify the promotion and truncation is legal
> regardless of whether an actual user is compiled or not.
>
Yes, that's the right thing to do. I'll fix it up and commit a patch.
-hpa
next prev parent reply other threads:[~2009-02-13 22:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-bf33a70a73876b163d62612e9567cbac6604ba7e@kernel.org>
2009-02-13 20:14 ` [tip:x86/headers] x86: fix "__udivdi3" [drivers/scsi/aha1542.ko] undefined H. Peter Anvin
2009-02-13 21:36 ` James Bottomley
2009-02-13 22:51 ` H. Peter Anvin [this message]
2009-02-14 7:36 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4995F979.9040304@zytor.com \
--to=hpa@zytor.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.