All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@csr.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] wusb: Storage class should be before const qualifier
Date: Mon, 16 Feb 2009 14:04:28 +0000	[thread overview]
Message-ID: <4999726C.3070706@csr.com> (raw)
In-Reply-To: <20090209220735.GA8082@xenon.distanz.ch>

Jiri Kosina wrote:
> On Mon, 9 Feb 2009, Tobias Klauser wrote:
> 
>> The C99 specification states in section 6.11.5:
>>
>> The placement of a storage-class specifier other than at the beginning
>> of the declaration specifiers in a declaration is an obsolescent
>> feature.
>>
>> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
>> ---
>>  include/linux/usb/wusb.h |    3 +--
>>  1 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/linux/usb/wusb.h b/include/linux/usb/wusb.h
>> index 5f401b6..429c631 100644
>> --- a/include/linux/usb/wusb.h
>> +++ b/include/linux/usb/wusb.h
>> @@ -80,8 +80,7 @@ struct wusb_ckhdid {
>>  	u8 data[16];
>>  } __attribute__((packed));
>>  
>> -const static
>> -struct wusb_ckhdid wusb_ckhdid_zero = { .data = { 0 } };
>> +static const struct wusb_ckhdid wusb_ckhdid_zero = { .data = { 0 } };
>>  
>>  #define WUSB_CKHDID_STRSIZE (3 * sizeof(struct wusb_ckhdid) + 1)
> 
> David, are you going to take this through wusb tree, or should I take it 
> through trivial tree together with the rest of these patches? I don't seem 
> to see this present in current -next.

Through trivial is best I think, thanks.  You can add

Acked-by: David Vrabel <david.vrabel@csr.com>

if you wish.

David
-- 
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park,  Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ                 http://www.csr.com/

  parent reply	other threads:[~2009-02-16 14:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-09 22:07 [PATCH] wusb: Storage class should be before const qualifier Tobias Klauser
2009-02-16 12:58 ` Jiri Kosina
2009-02-16 14:04 ` David Vrabel [this message]
2009-02-16 14:11 ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4999726C.3070706@csr.com \
    --to=david.vrabel@csr.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.