From: Patrick McHardy <kaber@trash.net>
To: Adam Nielsen <a.nielsen@shikadi.net>
Cc: Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>,
rpurdie@linux.intel.com
Subject: Re: [PATCH 2/2 v5] New netfilter target to trigger LED devices
Date: Mon, 16 Feb 2009 17:03:56 +0100 [thread overview]
Message-ID: <49998E6C.2030504@trash.net> (raw)
In-Reply-To: <49940D58.3040404@shikadi.net>
Adam Nielsen wrote:
> Kernel module providing implementation of LED netfilter target. Each
> instance of the target appears as a led-trigger device, which can be
> associated with one or more LEDs in /sys/class/leds/
>
> Signed-off-by: Adam Nielsen <a.nielsen@shikadi.net>
>
> ---
>
> Thanks for the feedback Patrick - here is the updated version with
> your suggestions:
>
> - Mutexes removed - I concede that missing a blink here and there
> is acceptable :-)
> - KERN_ERR used for non-critical errors, all KERN_NOTICEs removed
> - Split assignment out from comparison in kzalloc()
>
> Hope this one's okay!
Apart from some minor cosmetic issues that I'm simply going to
fix up when applying, it looks fine to me. If Richard is also
ok with this I'll apply it.
next prev parent reply other threads:[~2009-02-16 16:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 21:45 [PATCH 2/2 v4] New netfilter target to trigger LED devices Adam Nielsen
2009-02-12 5:27 ` Patrick McHardy
2009-02-12 11:51 ` [PATCH 2/2 v5] " Adam Nielsen
2009-02-16 16:03 ` Patrick McHardy [this message]
2009-02-17 13:50 ` Richard Purdie
2009-02-18 14:14 ` Patrick McHardy
2009-02-18 22:20 ` Adam Nielsen
2009-02-19 10:14 ` Patrick McHardy
2009-02-20 9:57 ` Patrick McHardy
2009-02-22 14:16 ` Adam Nielsen
2009-02-24 13:51 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49998E6C.2030504@trash.net \
--to=kaber@trash.net \
--cc=a.nielsen@shikadi.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=rpurdie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.