All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Adam Nielsen <a.nielsen@shikadi.net>
Cc: Netfilter Developer Mailing List <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH 2/2 v5] New netfilter target to trigger LED devices
Date: Tue, 24 Feb 2009 14:51:02 +0100	[thread overview]
Message-ID: <49A3FB46.5060306@trash.net> (raw)
In-Reply-To: <49A15E3C.3090809@shikadi.net>

Adam Nielsen wrote:
>> Applied, thanks. I've made some minor cosmetic changes, like removal
>> of /* noconst */ annotations and fixing indentation in one spot.
>>
>> You can look at the final commit at:
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/kaber/nf-next-2.6.git
> 
> Thanks Patrick, looks fine.  Did you fix the compile errors in your 
> other post, or do you still want me to look at them?  It looks like it 
> was compiled with LED support disabled, which I thought the kernel 
> should take care of (not allowing the file to be compiled if LED support 
> was not present.)

I did enable LED support to be able to select it. Might be a mistake
when rebuilding on my side though, the latest patch compiles cleanly.

> Did the other companion patch (1/2, the one to netfilter) also get 
> committed?  Without that the new kernel module won't ever be used.

That will get committed when the new -rc window starts so we don't
include the userspace code in a release before the kernel part is
released (and thus still can fix any mistakes that come up).

      reply	other threads:[~2009-02-24 13:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-11 21:45 [PATCH 2/2 v4] New netfilter target to trigger LED devices Adam Nielsen
2009-02-12  5:27 ` Patrick McHardy
2009-02-12 11:51   ` [PATCH 2/2 v5] " Adam Nielsen
2009-02-16 16:03     ` Patrick McHardy
2009-02-17 13:50       ` Richard Purdie
2009-02-18 14:14         ` Patrick McHardy
2009-02-18 22:20           ` Adam Nielsen
2009-02-19 10:14             ` Patrick McHardy
2009-02-20  9:57             ` Patrick McHardy
2009-02-22 14:16               ` Adam Nielsen
2009-02-24 13:51                 ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49A3FB46.5060306@trash.net \
    --to=kaber@trash.net \
    --cc=a.nielsen@shikadi.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.