modpost: Something amiss with do_hid_entry() - id->bus endianess wrong?

modpost: Something amiss with do_hid_entry() - id->bus endianess wrong?

[Nye Liu]

i am having problems with endianness on the id->bus value in do_hid_entry().

i think there is a "TO_NATIVE(id->bus);" missing in scripts/mod/file2alias.c:

# modinfo --version
module-init-tools version 3.4
# modinfo hid_dell
filename:
/lib/modules/2.6.28-1-amd64/kernel/drivers/hid/hid-dell.ko
license:        GPL
alias:          hid:b0300v000013BAp00000017
alias:          hid:b0300v0000413Cp00002105
alias:          hid:b0300v0000413Cp00002005
depends:        hid,usbhid
vermagic:       2.6.28-1-amd64 SMP mod_unload modversions 

notice it says "b0300", but the proper hid bus id is 0x0003 (from udev):
[ 2374.572122] dell 0003:413C:2005.0006: input,hidraw1: USB HID v1.10 Keyboard [DELL DELL USB Keyboard] on usb-0000:00:1d.3-2/input0 

this is preventing udev from autoloading any of the usbhid modules
unless you hack modules.alias

or do i have an outdated modinfo/modutils?

-- 
Nye Liu
nliu@mrv.com
(818) 772-6235x248
(818) 772-0576 fax

"Who would be stupid enough to quote a fictitious character?"
	-- Don Quixote

Re: modpost: Something amiss with do_hid_entry() - id->bus endianess wrong?

[Jiri Slaby]

Nye Liu wrote:
> i am having problems with endianness on the id->bus value in do_hid_entry().
> 
> i think there is a "TO_NATIVE(id->bus);" missing in scripts/mod/file2alias.c:

Definitely! Good spotting, thanks.

Could you try the patch I posted a minute ago?

Re: modpost: Something amiss with do_hid_entry() - id->bus endianess wrong?

[Nye Liu]

Jiri Slaby wrote:
> Nye Liu wrote:
>   
>> i am having problems with endianness on the id->bus value in do_hid_entry().
>>
>> i think there is a "TO_NATIVE(id->bus);" missing in scripts/mod/file2alias.c:
>>     
>
> Definitely! Good spotting, thanks.
>
> Could you try the patch I posted a minute ago?
>   
Yes, it works; i posted an almost identical patch not long before you did ;)

Re: modpost: Something amiss with do_hid_entry() - id->bus endianess wrong?

[Jiri Kosina]

On Tue, 17 Feb 2009, Nye Liu wrote:

> > > i am having problems with endianness on the id->bus value in
> > > do_hid_entry().
> > > i think there is a "TO_NATIVE(id->bus);" missing in
> > > scripts/mod/file2alias.c:
> > Definitely! Good spotting, thanks.
> > Could you try the patch I posted a minute ago?
> Yes, it works; i posted an almost identical patch not long before you did ;)

The patch is now in Linus' tree.

Thanks for spotting this,

-- 
Jiri Kosina
SUSE Labs