All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Thomas Jarosch <thomas.jarosch@intra2net.com>
Cc: Philip Craig <philipc@snapgear.com>,
	Jan Engelhardt <jengelh@medozas.de>,
	hadi@cyberus.ca, Pablo Neira Ayuso <pablo@netfilter.org>,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] libxtables: Dont initialize global xt_params
Date: Tue, 17 Feb 2009 15:54:06 +0100	[thread overview]
Message-ID: <499ACF8E.9080301@trash.net> (raw)
In-Reply-To: <200902171546.13305.thomas.jarosch@intra2net.com>

Thomas Jarosch wrote:
> On Monday, 16. February 2009 11:38:49 you wrote:
>> I think the 3.x versions don't do this by default, so as long as they're
>> supported by the kernel, we should expect people to use them and not
>> assume defaults of later versions.
> 
> Thanks for clearing this up, Philip and Patrick.
> 
> So we've got so far:
> 
> 1. Better readbility by writing "xyz = NULL;"
> 2. Correct and a tiny bit larger code using gcc 3
> 3. Correct and compact code using gcc 4 (released April 2005).
> 
> I guess the assembler code generated from gcc 3 <-> gcc 4
> will have other performance/size differences,
> but it's Patrick's final decision what to do :-)

I actually prefer no initializers for two reasons:

- it avoids these discussions that come up once every couple
   of months :)

- they're useless



  reply	other threads:[~2009-02-17 14:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-12 14:16 [PATCH] libxtables: Dont initialize global xt_params jamal
2009-02-12 15:09 ` Thomas Jarosch
2009-02-12 15:14   ` Jan Engelhardt
2009-02-12 15:41     ` Thomas Jarosch
2009-02-13 13:49       ` jamal
2009-02-13 18:11         ` Thomas Jarosch
2009-02-16  4:51       ` Philip Craig
2009-02-16 10:38         ` Patrick McHardy
2009-02-17 14:46           ` Thomas Jarosch
2009-02-17 14:54             ` Patrick McHardy [this message]
2009-02-12 16:39 ` jamal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=499ACF8E.9080301@trash.net \
    --to=kaber@trash.net \
    --cc=hadi@cyberus.ca \
    --cc=jengelh@medozas.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=philipc@snapgear.com \
    --cc=thomas.jarosch@intra2net.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.