* [PATCH] OSS: missing parentheses?
@ 2009-02-18 9:15 Roel Kluin
2009-02-18 10:40 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-02-18 9:15 UTC (permalink / raw)
To: tiwai; +Cc: alsa-devel, Andrew Morton
Please review.
--------------------------->8-------------8<------------------------------
Add missing parentheses
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/sound/oss/pas2_card.c b/sound/oss/pas2_card.c
index 25f3a22..7f377ec 100644
--- a/sound/oss/pas2_card.c
+++ b/sound/oss/pas2_card.c
@@ -156,9 +156,7 @@ static int __init config_pas_hw(struct address_info *hw_config)
* 0x80
*/ , 0xB88);
- pas_write(0x80
- | joystick?0x40:0
- ,0xF388);
+ pas_write(0x80 | (joystick ? 0x40 : 0), 0xF388);
if (pas_irq < 0 || pas_irq > 15)
{
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] OSS: missing parentheses?
2009-02-18 9:15 [PATCH] OSS: missing parentheses? Roel Kluin
@ 2009-02-18 10:40 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2009-02-18 10:40 UTC (permalink / raw)
To: Roel Kluin; +Cc: alsa-devel, Andrew Morton
At Wed, 18 Feb 2009 10:15:00 +0100,
Roel Kluin wrote:
>
> Please review.
> --------------------------->8-------------8<------------------------------
> Add missing parentheses
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/sound/oss/pas2_card.c b/sound/oss/pas2_card.c
> index 25f3a22..7f377ec 100644
> --- a/sound/oss/pas2_card.c
> +++ b/sound/oss/pas2_card.c
> @@ -156,9 +156,7 @@ static int __init config_pas_hw(struct address_info *hw_config)
> * 0x80
> */ , 0xB88);
>
> - pas_write(0x80
> - | joystick?0x40:0
> - ,0xF388);
> + pas_write(0x80 | (joystick ? 0x40 : 0), 0xF388);
Yes, obviously a bug. Applied now.
Thanks!
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-18 10:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-18 9:15 [PATCH] OSS: missing parentheses? Roel Kluin
2009-02-18 10:40 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.