From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Paul Mundt <lethal@linux-sh.org>,
linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
linux-mm@vger.kernel.org,
Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [PATCH] slab: fix slab flags for archs use alignment larger
Date: Wed, 18 Feb 2009 08:31:15 +0000 [thread overview]
Message-ID: <499BD53C.1000007@st.com> (raw)
In-Reply-To: <84144f020902130541n6de09d7brb455d0879b62af71@mail.gmail.com>
Hi Pekka,
Pekka Enberg wrote:
> Hi Giuseppe,
>
> On Fri, Feb 13, 2009 at 4:11 PM, Giuseppe CAVALLARO
> <peppe.cavallaro@st.com> wrote:
>
>> @@ -2262,7 +2266,7 @@ kmem_cache_create (const char *name, size_t size, size_t align,
>> ralign = align;
>> }
>> /* disable debug if necessary */
>> - if (ralign > __alignof__(unsigned long long))
>> + if (ralign > ARCH_SLAB_MAX_DEBUG_ALIGN)
>> flags &= ~(SLAB_RED_ZONE | SLAB_STORE_USER);
>> /*
>> * 4) Store it.
>>
>
> This doesn't address the issues raised by Paul at all.
>
> Pekka
>
Sorry for my late reply.
You are right.
I'm going to review this but this could take a while.
I'll go back to you as soon as possible.
Regards,
Peppe
//
WARNING: multiple messages have this Message-ID (diff)
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Paul Mundt <lethal@linux-sh.org>,
linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
linux-mm@vger.kernel.org,
Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [PATCH] slab: fix slab flags for archs use alignment larger 64-bit
Date: Wed, 18 Feb 2009 10:30:36 +0100 [thread overview]
Message-ID: <499BD53C.1000007@st.com> (raw)
In-Reply-To: <84144f020902130541n6de09d7brb455d0879b62af71@mail.gmail.com>
Hi Pekka,
Pekka Enberg wrote:
> Hi Giuseppe,
>
> On Fri, Feb 13, 2009 at 4:11 PM, Giuseppe CAVALLARO
> <peppe.cavallaro@st.com> wrote:
>
>> @@ -2262,7 +2266,7 @@ kmem_cache_create (const char *name, size_t size, size_t align,
>> ralign = align;
>> }
>> /* disable debug if necessary */
>> - if (ralign > __alignof__(unsigned long long))
>> + if (ralign > ARCH_SLAB_MAX_DEBUG_ALIGN)
>> flags &= ~(SLAB_RED_ZONE | SLAB_STORE_USER);
>> /*
>> * 4) Store it.
>>
>
> This doesn't address the issues raised by Paul at all.
>
> Pekka
>
Sorry for my late reply.
You are right.
I'm going to review this but this could take a while.
I'll go back to you as soon as possible.
Regards,
Peppe
//
next prev parent reply other threads:[~2009-02-18 8:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 17:51 [PATCH] slab: fix slab flags for archs use alignment larger 64-bit Giuseppe CAVALLARO
2009-02-12 18:56 ` Paul Mundt
2009-02-12 18:56 ` Paul Mundt
2009-02-13 9:00 ` Giuseppe CAVALLARO
2009-02-13 10:00 ` Giuseppe CAVALLARO
2009-02-13 9:22 ` [PATCH] slab: fix slab flags for archs use alignment larger Pekka Enberg
2009-02-13 9:22 ` [PATCH] slab: fix slab flags for archs use alignment larger 64-bit Pekka Enberg
2009-02-13 9:30 ` [PATCH] slab: fix slab flags for archs use alignment larger Pekka Enberg
2009-02-13 9:30 ` [PATCH] slab: fix slab flags for archs use alignment larger 64-bit Pekka Enberg
2009-02-13 9:30 ` Pekka Enberg
2009-02-13 9:47 ` [PATCH] slab: fix slab flags for archs use alignment larger Giuseppe CAVALLARO
2009-02-13 10:46 ` [PATCH] slab: fix slab flags for archs use alignment larger 64-bit Giuseppe CAVALLARO
2009-02-13 10:05 ` [PATCH] slab: fix slab flags for archs use alignment larger Pekka Enberg
2009-02-13 10:05 ` [PATCH] slab: fix slab flags for archs use alignment larger 64-bit Pekka Enberg
2009-02-13 10:16 ` [PATCH] slab: fix slab flags for archs use alignment larger Giuseppe CAVALLARO
2009-02-13 11:15 ` [PATCH] slab: fix slab flags for archs use alignment larger 64-bit Giuseppe CAVALLARO
2009-02-13 13:11 ` [PATCH] slab: fix slab flags for archs use alignment larger Giuseppe CAVALLARO
2009-02-13 14:11 ` [PATCH] slab: fix slab flags for archs use alignment larger 64-bit Giuseppe CAVALLARO
2009-02-13 13:41 ` [PATCH] slab: fix slab flags for archs use alignment larger Pekka Enberg
2009-02-13 13:41 ` [PATCH] slab: fix slab flags for archs use alignment larger 64-bit Pekka Enberg
2009-02-18 8:31 ` Giuseppe CAVALLARO [this message]
2009-02-18 9:30 ` Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499BD53C.1000007@st.com \
--to=peppe.cavallaro@st.com \
--cc=cl@linux-foundation.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.