All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Rusty Russell <rusty@rustcorp.com.au>
Subject: [PATCH] module: fix build for CONFIG_SYSFS=n
Date: Wed, 18 Feb 2009 10:02:29 -0800	[thread overview]
Message-ID: <499C4D35.9000104@oracle.com> (raw)
In-Reply-To: <20090218191640.0b023029.sfr@canb.auug.org.au>

From: Randy Dunlap <randy.dunlap@oracle.com>

Fix this build error when CONFIG_SYSFS=n:

kernel/built-in.o: In function `free_module':
module.c:(.text+0x4f8a2): undefined reference to `destroy_params'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
cc: Rusty Russell <rusty@rustcorp.com.au>
---
 kernel/module.c |    2 ++
 1 file changed, 2 insertions(+)

--- linux-next-20090218.orig/kernel/module.c
+++ linux-next-20090218/kernel/module.c
@@ -1464,8 +1464,10 @@ static void free_module(struct module *m
 	/* Module unload stuff */
 	module_unload_free(mod);
 
+#ifdef CONFIG_SYSFS
 	/* Free any allocated parameters. */
 	destroy_params(mod->kp, mod->num_kp);
+#endif
 
 	/* release any pointers to mcount in this module */
 	ftrace_release(mod->module_core, mod->core_size);

  parent reply	other threads:[~2009-02-18 18:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-18  8:16 linux-next: Tree for February 18 Stephen Rothwell
2009-02-18 10:29 ` [s390] next Feb 18: defconfig build break Sachin P. Sant
2009-02-18 11:45   ` Stephen Rothwell
2009-02-18 17:10     ` Mike Frysinger
2009-02-18 22:43       ` Rusty Russell
2009-02-19  5:20         ` Sachin P. Sant
2009-02-20 10:23         ` Martin Schwidefsky
2009-02-18 22:59       ` Rusty Russell
2009-02-19  1:55         ` Mike Frysinger
2009-02-19 11:40           ` Rusty Russell
2009-02-19 17:14             ` Mike Frysinger
2009-02-19  0:15       ` Rusty Russell
2009-02-19  9:51         ` Russell King
2009-02-19 11:48           ` Rusty Russell
2009-02-18 18:02 ` Randy Dunlap [this message]
2009-02-18 18:09   ` [PATCH] module: fix build for CONFIG_SYSFS=n Ingo Molnar
2009-02-18 18:35     ` [PATCH v2] " Randy Dunlap
2009-02-18 19:15       ` Ingo Molnar
2009-02-19 10:50         ` Rusty Russell
2009-02-19  7:32       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=499C4D35.9000104@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.