From: Randy Dunlap <randy.dunlap@oracle.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: [PATCH v2] module: fix build for CONFIG_SYSFS=n
Date: Wed, 18 Feb 2009 10:35:20 -0800 [thread overview]
Message-ID: <499C54E8.7060004@oracle.com> (raw)
In-Reply-To: <20090218180932.GC19995@elte.hu>
> Is destroy_params() dependent on SYSFS? If yes then it would be
Yes.
> far cleaner if there was a NOP destroy_params() inline for the
> !SYSFS case.
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix this build error when CONFIG_SYSFS=n:
kernel/built-in.o: In function `free_module':
module.c:(.text+0x4f8a2): undefined reference to `destroy_params'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
cc: Rusty Russell <rusty@rustcorp.com.au>
---
kernel/params.c | 6 ++++++
1 file changed, 6 insertions(+)
--- linux-next-20090218.orig/kernel/params.c
+++ linux-next-20090218/kernel/params.c
@@ -761,6 +761,12 @@ static int __init param_sysfs_init(void)
}
subsys_initcall(param_sysfs_init);
+#else /* !CONFIG_SYSFS */
+
+inline void destroy_params(const struct kernel_param *params, unsigned num)
+{
+}
+
#endif /* CONFIG_SYSFS */
EXPORT_SYMBOL(param_set_byte);
next prev parent reply other threads:[~2009-02-18 18:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 8:16 linux-next: Tree for February 18 Stephen Rothwell
2009-02-18 10:29 ` [s390] next Feb 18: defconfig build break Sachin P. Sant
2009-02-18 11:45 ` Stephen Rothwell
2009-02-18 17:10 ` Mike Frysinger
2009-02-18 22:43 ` Rusty Russell
2009-02-19 5:20 ` Sachin P. Sant
2009-02-20 10:23 ` Martin Schwidefsky
2009-02-18 22:59 ` Rusty Russell
2009-02-19 1:55 ` Mike Frysinger
2009-02-19 11:40 ` Rusty Russell
2009-02-19 17:14 ` Mike Frysinger
2009-02-19 0:15 ` Rusty Russell
2009-02-19 9:51 ` Russell King
2009-02-19 11:48 ` Rusty Russell
2009-02-18 18:02 ` [PATCH] module: fix build for CONFIG_SYSFS=n Randy Dunlap
2009-02-18 18:09 ` Ingo Molnar
2009-02-18 18:35 ` Randy Dunlap [this message]
2009-02-18 19:15 ` [PATCH v2] " Ingo Molnar
2009-02-19 10:50 ` Rusty Russell
2009-02-19 7:32 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499C54E8.7060004@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.