From: Jeff Garzik <jeff@garzik.org>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: linux-nfs@vger.kernel.org, linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: NFS4ERR_DENIED becomes EIO?
Date: Wed, 18 Feb 2009 20:22:48 -0500 [thread overview]
Message-ID: <499CB468.7050702@garzik.org> (raw)
In-Reply-To: <1234994399.8412.206.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
Trond Myklebust wrote:
> On Wed, 2009-02-18 at 16:19 -0500, Jeff Garzik wrote:
>> I think I may have found a tiny NFSv4 client bug. What I am seeing:
>>
>> 1. On Linux NFS client (2.6.29-rc2), issue chown(1) to change the owner
>> of the file (causing SETATTR:OWNER to be issued)
>>
>> 2. My userland NFS server returns NFS4ERR_DENIED for the SETATTR op
>>
>> 3. Linux NFS client returns EIO (I/O error) to userland
>>
>> That was a bit unexpected. I would have guessed EPERM, perhaps.
>>
>> Jeff
>
> I'd put this down as a server bug, as rfc 3530 really reserves the error
> NFS4ERR_DENIED for the LOCK/LOCKT/LOCKU operations.
>
> In the case of a chown(), I'd expect the server to return NFS4ERR_PERM
> when failing because the caller is not root or the file owner. The
> client will then correctly translate that into an EPERM...
So noted... thanks a bunch! I'll make that change.
Jeff
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jeff-o2qLIJkoznsdnm+yROfE0A@public.gmane.org>
To: Trond Myklebust
<trond.myklebust-41N18TsMXrtuMpJDpNschA@public.gmane.org>
Cc: linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-fsdevel
<linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: NFS4ERR_DENIED becomes EIO?
Date: Wed, 18 Feb 2009 20:22:48 -0500 [thread overview]
Message-ID: <499CB468.7050702@garzik.org> (raw)
In-Reply-To: <1234994399.8412.206.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
Trond Myklebust wrote:
> On Wed, 2009-02-18 at 16:19 -0500, Jeff Garzik wrote:
>> I think I may have found a tiny NFSv4 client bug. What I am seeing:
>>
>> 1. On Linux NFS client (2.6.29-rc2), issue chown(1) to change the owner
>> of the file (causing SETATTR:OWNER to be issued)
>>
>> 2. My userland NFS server returns NFS4ERR_DENIED for the SETATTR op
>>
>> 3. Linux NFS client returns EIO (I/O error) to userland
>>
>> That was a bit unexpected. I would have guessed EPERM, perhaps.
>>
>> Jeff
>
> I'd put this down as a server bug, as rfc 3530 really reserves the error
> NFS4ERR_DENIED for the LOCK/LOCKT/LOCKU operations.
>
> In the case of a chown(), I'd expect the server to return NFS4ERR_PERM
> when failing because the caller is not root or the file owner. The
> client will then correctly translate that into an EPERM...
So noted... thanks a bunch! I'll make that change.
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-02-19 1:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 21:19 NFS4ERR_DENIED becomes EIO? Jeff Garzik
2009-02-18 21:19 ` Jeff Garzik
2009-02-18 21:59 ` Trond Myklebust
2009-02-18 21:59 ` Trond Myklebust
[not found] ` <1234994399.8412.206.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-02-19 1:22 ` Jeff Garzik [this message]
2009-02-19 1:22 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499CB468.7050702@garzik.org \
--to=jeff@garzik.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.