Re: [PATCH] pci: enable MSI on 8132

[Robert Hancock <hancockrwd@gmail.com>]

Yinghai Lu wrote:
> Impact: workaround BIOS that doesn't enable that bit
> 
> David reported that LSI sas doesn't work with MSI.
> it turns out that BIOS doesn't enable HT MSI
> 8132 does support HT MSI.
> add quirk to enable it
> 
> Reported-by: David Lang <david@lang.hm>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> 
> ---
>  drivers/pci/quirks.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Index: linux-2.6/drivers/pci/quirks.c
> ===================================================================
> --- linux-2.6.orig/drivers/pci/quirks.c
> +++ linux-2.6/drivers/pci/quirks.c
> @@ -1981,7 +1981,6 @@ static void __devinit quirk_msi_ht_cap(s
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_HT2000_PCIE,
>  			quirk_msi_ht_cap);
>  
> -
>  /* The nVidia CK804 chipset may have 2 HT MSI mappings.
>   * MSI are supported if the MSI capability set in any of these mappings.
>   */
> @@ -2032,6 +2031,9 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_S
>  			 PCI_DEVICE_ID_SERVERWORKS_HT1000_PXB,
>  			 ht_enable_msi_mapping);
>  
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_8132_BRIDGE,
> +			 ht_enable_msi_mapping);
> +

Is there a reason why we can't just enable the HT MSI mapping for any 
bridge device that has that PCI capability and is underneath an HT 
bridge? Essentially the code for nv_msi_ht_cap_quirk could potentially 
be applied to all bridges as it is currently for NVIDIA and ALi bridges..