Re: [PATCH] pci: don't enable too many HT MSI mapping

[Yinghai Lu <yinghai@kernel.org>]

Prakash Punnoor wrote:
> [PATCH] Enable HT MSI mapping on all known needed NVidia host bridges
> 
> v3 of Yinghai Lu's work only enables HT MSI mapping for one specific host bridge.
> Do this also for all known needed ones as specified by NVidia's original patch.
> 
> Signed-off-by: Prakash Punnoor <prakash@punnoor.de>
> 
> --- drivers/pci/quirks.c.current	2009-03-01 08:42:31.321660493 +0100
> +++ drivers/pci/quirks.c	2009-03-01 08:47:47.267657376 +0100
> @@ -2189,8 +2189,20 @@
>  	return __nv_msi_ht_cap_quirk(dev, 0);
>  }
>  
> -/* werid?, c51/mcp51 need c51 ht msi to be enable to make mcp51 ht msi working */
> +/* Enable HT MSI mapping on following host brigdes */
> +/* C51 host bridges */
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NVIDIA, 0x02f0, nv_msi_ht_cap_quirk_all);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NVIDIA, 0x02f1, nv_msi_ht_cap_quirk_all);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NVIDIA, 0x02f2, nv_msi_ht_cap_quirk_all);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NVIDIA, 0x02f3, nv_msi_ht_cap_quirk_all);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NVIDIA, 0x02f4, nv_msi_ht_cap_quirk_all);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NVIDIA, 0x02f5, nv_msi_ht_cap_quirk_all);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NVIDIA, 0x02f6, nv_msi_ht_cap_quirk_all);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NVIDIA, 0x02f7, nv_msi_ht_cap_quirk_all);
> +/* MCP55 host bridge */
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NVIDIA, 0x0369, nv_msi_ht_cap_quirk_all);
we may not need this one.
mcp55 is some kind of mcp51 equivent, so we dont't HT MSI for 0x0369

YH

> +
> +/* Enable MSI mapping on all regular devices */
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID, nv_msi_ht_cap_quirk_leaf);
>  
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AL, PCI_ANY_ID, nv_msi_ht_cap_quirk_all);