From: Gerd Hoffmann <kraxel@redhat.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Xen Development Mailing List <xen-devel@lists.xensource.com>,
Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: Re: pv_ops parport trouble
Date: Thu, 19 Feb 2009 17:31:38 +0100 [thread overview]
Message-ID: <499D896A.5050202@redhat.com> (raw)
In-Reply-To: <499D878F.4070906@goop.org>
[-- Attachment #1: Type: text/plain, Size: 254 bytes --]
Jeremy Fitzhardinge wrote:
> I guess that's possible, but the code in question does just pass the
> trigger and polarity straight through.
Notice:
#define ACPI_LEVEL_SENSITIVE (u8) 0x00
whereas for the io apic 0 == edge.
cheers,
Gerd
[-- Attachment #2: fix --]
[-- Type: text/plain, Size: 428 bytes --]
diff --git a/arch/x86/xen/pci.c b/arch/x86/xen/pci.c
index d661c74..62ab389 100644
--- a/arch/x86/xen/pci.c
+++ b/arch/x86/xen/pci.c
@@ -53,7 +53,7 @@ int xen_register_gsi(u32 gsi, int triggering, int polarity)
printk(KERN_DEBUG "xen: --> irq=%d\n", irq);
if (irq > 0)
- xen_set_io_apic_routing(irq, triggering, polarity);
+ xen_set_io_apic_routing(irq, triggering == ACPI_LEVEL_SENSITIVE, polarity);
return irq;
}
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2009-02-19 16:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 14:38 pv_ops parport trouble Gerd Hoffmann
2009-02-19 15:28 ` Gerd Hoffmann
2009-02-19 16:07 ` Keir Fraser
2009-02-19 16:23 ` Jeremy Fitzhardinge
2009-02-19 16:31 ` Gerd Hoffmann [this message]
2009-02-19 16:37 ` Jeremy Fitzhardinge
2009-02-19 16:45 ` Gerd Hoffmann
2009-02-19 16:49 ` Jeremy Fitzhardinge
2009-02-19 16:56 ` Gerd Hoffmann
2009-02-19 17:11 ` Keir Fraser
2009-02-19 16:51 ` Keir Fraser
2009-02-19 17:08 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499D896A.5050202@redhat.com \
--to=kraxel@redhat.com \
--cc=jeremy@goop.org \
--cc=keir.fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.