[U-Boot] [PATCH] ARM:PXA Use new definitions in mmc.h

[U-Boot] [PATCH] ARM:PXA Use new definitions in mmc.h

[Tom Rix]

In old code or current u-boot-arm MMC_CMD_WRITE_BLOCK == 24.
In new mmc.h 24 is MMC_CMD_WRITE_SINGLE_BLOCK

Change mmc_read to conform to mmc.h declaration.

Signed-off-by: Tom Rix <Tom.Rix@windriver.com>
---
 cpu/pxa/mmc.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/cpu/pxa/mmc.c b/cpu/pxa/mmc.c
index 8f5277e..f92c089 100644
--- a/cpu/pxa/mmc.c
+++ b/cpu/pxa/mmc.c
@@ -181,7 +181,7 @@ mmc_block_write(ulong dst, uchar * src, int len)
 	MMC_STRPCL = MMC_STRPCL_STOP_CLK;
 	MMC_NOB = 1;
 	MMC_BLKLEN = len;
-	mmc_cmd(MMC_CMD_WRITE_BLOCK, argh, argl,
+	mmc_cmd(MMC_CMD_WRITE_SINGLE_BLOCK, argh, argl,
 		MMC_CMDAT_R1 | MMC_CMDAT_WRITE | MMC_CMDAT_BLOCK |
 		MMC_CMDAT_DATA_EN);
 
@@ -218,7 +218,7 @@ mmc_block_write(ulong dst, uchar * src, int len)
 
 int
 /****************************************************/
-mmc_read(ulong src, uchar * dst, int size)
+mmc_read(struct mmc *mmc, u64 src, uchar * dst, int size)
 /****************************************************/
 {
 	ulong end, part_start, part_end, part_len, aligned_start, aligned_end;
@@ -383,7 +383,7 @@ mmc_bread(int dev_num, ulong blknr, lbaint_t blkcnt, void *dst)
 	int mmc_block_size = MMC_BLOCK_SIZE;
 	ulong src = blknr * mmc_block_size + CONFIG_SYS_MMC_BASE;
 
-	mmc_read(src, (uchar *) dst, blkcnt * mmc_block_size);
+	mmc_read(NULL, src, (uchar *) dst, blkcnt * mmc_block_size);
 	return blkcnt;
 }
 
-- 
1.6.0.5

[U-Boot] [PATCH] ARM:PXA Use new definitions in mmc.h

[Jean-Christophe PLAGNIOL-VILLARD]

On 19:53 Thu 19 Feb     , Tom Rix wrote:
> In old code or current u-boot-arm MMC_CMD_WRITE_BLOCK == 24.
> In new mmc.h 24 is MMC_CMD_WRITE_SINGLE_BLOCK
> 
> Change mmc_read to conform to mmc.h declaration.
> 
> Signed-off-by: Tom Rix <Tom.Rix@windriver.com>
> ---
NACK the drivers need to be really update
but for now we juct rename this function

please take a look on this
Subject: [PATCH 4/8 V2] Reduce the scope of PXA's mmc_read/mmc_write/mmc_bread
functions   

Best Regards,
J.

[U-Boot] [PATCH] ARM:PXA Use new definitions in mmc.h

[Tom]

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 19:53 Thu 19 Feb     , Tom Rix wrote:
>   
>> In old code or current u-boot-arm MMC_CMD_WRITE_BLOCK == 24.
>> In new mmc.h 24 is MMC_CMD_WRITE_SINGLE_BLOCK
>>
>> Change mmc_read to conform to mmc.h declaration.
>>
>> Signed-off-by: Tom Rix <Tom.Rix@windriver.com>
>> ---
>>     
> NACK the drivers need to be really update
> but for now we juct rename this function
>
> please take a look on this
> Subject: [PATCH 4/8 V2] Reduce the scope of PXA's mmc_read/mmc_write/mmc_bread
> functions   
>
> Best Regards,
> J.
>   
I see the patch at.
http://www.mail-archive.com/u-boot at lists.denx.de/msg08137.html
Do you want me to go ahead with this or wait for someone with a pxa 
target to run this down?

Tom

[U-Boot] [PATCH] ARM:PXA Use new definitions in mmc.h

[Jean-Christophe PLAGNIOL-VILLARD]

On 20:45 Thu 19 Feb     , Tom wrote:
> Jean-Christophe PLAGNIOL-VILLARD wrote:
>> On 19:53 Thu 19 Feb     , Tom Rix wrote:
>>   
>>> In old code or current u-boot-arm MMC_CMD_WRITE_BLOCK == 24.
>>> In new mmc.h 24 is MMC_CMD_WRITE_SINGLE_BLOCK
>>>
>>> Change mmc_read to conform to mmc.h declaration.
>>>
>>> Signed-off-by: Tom Rix <Tom.Rix@windriver.com>
>>> ---
>>>     
>> NACK the drivers need to be really update
>> but for now we juct rename this function
>>
>> please take a look on this
>> Subject: [PATCH 4/8 V2] Reduce the scope of PXA's mmc_read/mmc_write/mmc_bread
>> functions   
>>
>> Best Regards,
>> J.
>>   
> I see the patch at.
> http://www.mail-archive.com/u-boot at lists.denx.de/msg08137.html
> Do you want me to go ahead with this or wait for someone with a pxa  
> target to run this down?
I've send the updated patch and pull request

Best Regards,
J.