All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Tomonari Horikoshi <t.horikoshi@jp.fujitsu.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] ioemu : add flush in ide_unplug_harddisks()
Date: Fri, 20 Feb 2009 11:40:03 +0000	[thread overview]
Message-ID: <499E9693.3060708@eu.citrix.com> (raw)
In-Reply-To: <81C9930B79FFCBt.horikoshi@jp.fujitsu.com>

Tomonari Horikoshi wrote:

> Hi
> 
> I think the "flush" is necessary. 
> When "ioemu ide device" changes into "vbd" by "ide_unplug_harddisks()". 
> 
> What do you think?
> 
> 

I don't think that calling bdrv_aio_flush is a good idea since it is
asyncronous and right after the call we are going to close the device
without waiting for completion.

  reply	other threads:[~2009-02-20 11:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-20  3:29 [PATCH] ioemu : add flush in ide_unplug_harddisks() Tomonari Horikoshi
2009-02-20 11:40 ` Stefano Stabellini [this message]
2009-02-23 16:41   ` Ian Jackson
2009-02-23 23:46     ` Tomonari Horikoshi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=499E9693.3060708@eu.citrix.com \
    --to=stefano.stabellini@eu.citrix.com \
    --cc=t.horikoshi@jp.fujitsu.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.