From: Marius Storm-Olsen <marius@trolltech.com>
To: Ted Pavlic <ted@tedpavlic.com>
Cc: spearce@spearce.org, Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Add bare repository indicator for __git_ps1
Date: Fri, 20 Feb 2009 23:00:25 +0100 [thread overview]
Message-ID: <499F27F9.8090506@trolltech.com> (raw)
In-Reply-To: <499EE324.4050305@tedpavlic.com>
Ted Pavlic said the following on 20.02.2009 18:06:
>> + if test "$(git config --bool core.bare)" == "true"; then
>
> As discussed in another thread, to be consistent with local coding
> convention, "test" should be replaced with "[ ... ]".
>
> Additionally, double equality (==) should be replaced with single
> equality (=).
Ok, I think I was based off of master at the time. I'll take a closer
look. Thanks!
--
.marius
next prev parent reply other threads:[~2009-02-20 22:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-20 14:56 [PATCH] Add bare repository indicator for __git_ps1 Marius Storm-Olsen
2009-02-20 16:35 ` Johannes Schindelin
2009-02-20 16:46 ` Thomas Rast
2009-02-20 17:13 ` Michael J Gruber
2009-02-20 22:04 ` Marius Storm-Olsen
2009-02-20 16:39 ` Michael J Gruber
2009-02-20 21:55 ` Marius Storm-Olsen
2009-02-20 17:06 ` Ted Pavlic
2009-02-20 22:00 ` Marius Storm-Olsen [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-02-21 14:48 Marius Storm-Olsen
2009-02-21 14:53 ` Marius Storm-Olsen
2009-02-21 19:29 ` Junio C Hamano
2009-02-21 19:43 ` Marius Storm-Olsen
2009-02-22 16:49 ` Junio C Hamano
2009-02-23 7:52 ` Marius Storm-Olsen
2009-02-23 15:42 ` Shawn O. Pearce
2009-02-23 16:03 ` Marius Storm-Olsen
2009-02-23 16:16 ` Shawn O. Pearce
2009-02-23 18:55 ` Marius Storm-Olsen
2009-02-24 1:35 ` Junio C Hamano
2009-02-24 14:25 ` Ted Pavlic
2009-02-24 14:46 ` Marius Storm-Olsen
2009-02-24 15:39 ` Ted Pavlic
2009-02-24 17:01 ` Junio C Hamano
2009-02-24 19:47 ` Marius Storm-Olsen
2009-02-25 6:08 ` Junio C Hamano
2009-02-25 6:46 ` Marius Storm-Olsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499F27F9.8090506@trolltech.com \
--to=marius@trolltech.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
--cc=ted@tedpavlic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.