All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marius Storm-Olsen <marius@trolltech.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Junio C Hamano <gitster@pobox.com>,
	Marius Storm-Olsen <git@storm-olsen.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] Add bare repository indicator for __git_ps1
Date: Mon, 23 Feb 2009 19:55:30 +0100	[thread overview]
Message-ID: <49A2F122.7090607@trolltech.com> (raw)
In-Reply-To: <20090223161657.GL22848@spearce.org>

Shawn O. Pearce said the following on 23.02.2009 17:16:
> Marius Storm-Olsen <marius@trolltech.com> wrote:
>> ^shrug^ at this point you and Junio can discuss what to do, as Junio  
>> already said
>>
>>   | "I do not understand the need for GIT_DIR! thing even
>>   |  less, but since we have that there already, I do not
>>   |  see a reason not to add this to the queue."
>>
>> And I have to agree with him. At this point, __git_ps1() is actually  
>> removing useful information from the prompt; at least it does for me.
> 
> *sigh*

Ops, I realize that it sounded like I was setting you two up against 
each other, which was not my intention! What I meant to say was, I've 
stated my case as clear as i can now, so you two can make a decision. 
I know Junio will listen to you, and I'd be fine if you said no, based 
on all the info I gave you. (Though I really didn't like the 
"GIT_DIR!"-branch, but oh well)


> OK.  I guess we include it then.
> 
> Acked-by: Shawn O. Pearce <spearce@spearce.org>

Thanks, and again, sorry if you felt I put you up against Junio!

--
.marius

  reply	other threads:[~2009-02-23 18:57 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-21 14:48 [PATCH] Add bare repository indicator for __git_ps1 Marius Storm-Olsen
2009-02-21 14:53 ` Marius Storm-Olsen
2009-02-21 19:29 ` Junio C Hamano
2009-02-21 19:43   ` Marius Storm-Olsen
2009-02-22 16:49     ` Junio C Hamano
2009-02-23  7:52       ` Marius Storm-Olsen
2009-02-23 15:42     ` Shawn O. Pearce
2009-02-23 16:03       ` Marius Storm-Olsen
2009-02-23 16:16         ` Shawn O. Pearce
2009-02-23 18:55           ` Marius Storm-Olsen [this message]
2009-02-24  1:35           ` Junio C Hamano
2009-02-24 14:25             ` Ted Pavlic
2009-02-24 14:46               ` Marius Storm-Olsen
2009-02-24 15:39                 ` Ted Pavlic
2009-02-24 17:01                   ` Junio C Hamano
2009-02-24 19:47                     ` Marius Storm-Olsen
2009-02-25  6:08                       ` Junio C Hamano
2009-02-25  6:46                         ` Marius Storm-Olsen
  -- strict thread matches above, loose matches on Subject: below --
2009-02-20 14:56 Marius Storm-Olsen
2009-02-20 16:35 ` Johannes Schindelin
2009-02-20 16:46   ` Thomas Rast
2009-02-20 17:13     ` Michael J Gruber
2009-02-20 22:04     ` Marius Storm-Olsen
2009-02-20 16:39 ` Michael J Gruber
2009-02-20 21:55   ` Marius Storm-Olsen
2009-02-20 17:06 ` Ted Pavlic
2009-02-20 22:00   ` Marius Storm-Olsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49A2F122.7090607@trolltech.com \
    --to=marius@trolltech.com \
    --cc=git@storm-olsen.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.