Re: [PATCH] Long linux kernel command lines

[Jan Alsenz <janalsenz@student.ethz.ch>]

[-- Attachment #1: Type: text/plain, Size: 867 bytes --]

Robert Millan wrote:
> On Tue, Feb 10, 2009 at 07:02:56PM +0100, Jan Alsenz wrote:
>> Hello!
>>
>> I just noticed, that the pc linux loader (loader/i386/pc/linux.c) always
>> truncates the kernel command line to less than 256 characters.
>> Well since I needed a longer command line, I fixed this problem.
> 
> Hi,
> 
> Thanks for your effort, but note that this can't be changed carelessly.  It's
> possible we have this limit for backward compatibility.
> 
> If newer versions of Linux allow a longer cmdline, our code should check for
> that instead.

If you look at the patch I send on Feb 11, I think it does all the necessary checks.

> Also, would be cool if you can check whether loader/i386/linux.c also has
> this problem.

Well, it uses a fixed 4k command-line area. But I don't know, if this is a
problem there.

Greets,

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]