From: phcoder <phcoder@gmail.com>
To: The development of GRUB 2 <grub-devel@gnu.org>,
janalsenz@student.ethz.ch
Subject: Re: [PATCH] Long linux kernel command lines
Date: Sat, 11 Apr 2009 01:37:50 +0200 [thread overview]
Message-ID: <49DFD84E.3070703@gmail.com> (raw)
In-Reply-To: <49A01F17.4030406@student.ethz.ch>
Grüüzzi
This part (now named linux16) is kept for backward compatibility only.
And it looks like current implementation of linux command doesn't suffer
this limitation. Can you confirm?
BTW I'm at ETH too
Jan Alsenz wrote:
> Robert Millan wrote:
>> On Tue, Feb 10, 2009 at 07:02:56PM +0100, Jan Alsenz wrote:
>>> Hello!
>>>
>>> I just noticed, that the pc linux loader (loader/i386/pc/linux.c) always
>>> truncates the kernel command line to less than 256 characters.
>>> Well since I needed a longer command line, I fixed this problem.
>> Hi,
>>
>> Thanks for your effort, but note that this can't be changed carelessly. It's
>> possible we have this limit for backward compatibility.
>>
>> If newer versions of Linux allow a longer cmdline, our code should check for
>> that instead.
>
> If you look at the patch I send on Feb 11, I think it does all the necessary checks.
>
>> Also, would be cool if you can check whether loader/i386/linux.c also has
>> this problem.
>
> Well, it uses a fixed 4k command-line area. But I don't know, if this is a
> problem there.
>
> Greets,
>
> Jan
>
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
--
Regards
Vladimir 'phcoder' Serbinenko
prev parent reply other threads:[~2009-04-10 23:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 18:02 [PATCH] Long linux kernel command lines Jan Alsenz
2009-02-10 19:58 ` phcoder
2009-02-10 20:09 ` Jan Alsenz
2009-02-11 12:48 ` Jan Alsenz
2009-02-21 14:57 ` Robert Millan
2009-02-21 15:34 ` Jan Alsenz
2009-04-10 23:37 ` phcoder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DFD84E.3070703@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
--cc=janalsenz@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.