* [2.6.28.7] BUG: using smp_processor_id() in preemptible [00000000] code: pageattr-test/207
@ 2009-02-23 18:37 Tilman Schmidt
2009-02-23 23:13 ` Andrew Morton
0 siblings, 1 reply; 7+ messages in thread
From: Tilman Schmidt @ 2009-02-23 18:37 UTC (permalink / raw)
To: linux-kernel
Booting the most recent stable kernel 2.6.28.7 on my workhorse machine
(Pentium D, openSUSE 10.3 32 bit userspace) produces rather a lot of
the following BUG messages:
<3>BUG: using smp_processor_id() in preemptible [00000000] code: pageattr-test/207
<4>caller is paravirt_get_lazy_mode+0xe/0x1b
<4>Pid: 207, comm: pageattr-test Not tainted 2.6.28.7-testing #1
<4>Call Trace:
<4> [<c0204760>] debug_smp_processor_id+0xac/0xc0
<4> [<c011ad90>] paravirt_get_lazy_mode+0xe/0x1b
<4> [<c011c925>] arch_flush_lazy_mmu_mode+0x8/0x19
<4> [<c011d07c>] change_page_attr_set_clr+0x283/0x28e
<4> [<c011d152>] change_page_attr_set+0xf/0x11
<4> [<c011d347>] do_pageattr_test+0x1f3/0x3e3
<4> [<c01247f1>] ? finish_task_switch+0xa0/0xa8
<4> [<c032f799>] ? schedule+0x462/0x472
<4> [<c0331353>] ? _spin_unlock_irqrestore+0x40/0x74
<4> [<c011d154>] ? do_pageattr_test+0x0/0x3e3
<4> [<c0139f1d>] kthread+0x3b/0x62
<4> [<c0139ee2>] ? kthread+0x0/0x62
<4> [<c0104a43>] kernel_thread_helper+0x7/0x10
They occur regularly in bursts of ten, separated by 30 second break.
The previous kernel:
ts@xenon:~> uname -a
Linux xenon 2.6.28.6-testing #1 SMP PREEMPT Wed Feb 18 21:05:30 CET 2009 i686 i686 i386 GNU/Linux
with identical config and userspace (double-checked this time ;-)
runs quite BUG-free.
HTH
Tilman
--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [2.6.28.7] BUG: using smp_processor_id() in preemptible [00000000] code: pageattr-test/207
2009-02-23 18:37 [2.6.28.7] BUG: using smp_processor_id() in preemptible [00000000] code: pageattr-test/207 Tilman Schmidt
@ 2009-02-23 23:13 ` Andrew Morton
2009-02-24 0:48 ` Tilman Schmidt
0 siblings, 1 reply; 7+ messages in thread
From: Andrew Morton @ 2009-02-23 23:13 UTC (permalink / raw)
To: Tilman Schmidt; +Cc: linux-kernel, stable, Jeremy Fitzhardinge, Ingo Molnar
On Mon, 23 Feb 2009 19:37:41 +0100
Tilman Schmidt <t.schmidt@phoenixsoftware.de> wrote:
> Booting the most recent stable kernel 2.6.28.7 on my workhorse machine
> (Pentium D, openSUSE 10.3 32 bit userspace) produces rather a lot of
> the following BUG messages:
>
> <3>BUG: using smp_processor_id() in preemptible [00000000] code: pageattr-test/207
> <4>caller is paravirt_get_lazy_mode+0xe/0x1b
> <4>Pid: 207, comm: pageattr-test Not tainted 2.6.28.7-testing #1
> <4>Call Trace:
> <4> [<c0204760>] debug_smp_processor_id+0xac/0xc0
> <4> [<c011ad90>] paravirt_get_lazy_mode+0xe/0x1b
> <4> [<c011c925>] arch_flush_lazy_mmu_mode+0x8/0x19
> <4> [<c011d07c>] change_page_attr_set_clr+0x283/0x28e
> <4> [<c011d152>] change_page_attr_set+0xf/0x11
> <4> [<c011d347>] do_pageattr_test+0x1f3/0x3e3
> <4> [<c01247f1>] ? finish_task_switch+0xa0/0xa8
> <4> [<c032f799>] ? schedule+0x462/0x472
> <4> [<c0331353>] ? _spin_unlock_irqrestore+0x40/0x74
> <4> [<c011d154>] ? do_pageattr_test+0x0/0x3e3
> <4> [<c0139f1d>] kthread+0x3b/0x62
> <4> [<c0139ee2>] ? kthread+0x0/0x62
> <4> [<c0104a43>] kernel_thread_helper+0x7/0x10
>
> They occur regularly in bursts of ten, separated by 30 second break.
> The previous kernel:
>
> ts@xenon:~> uname -a
> Linux xenon 2.6.28.6-testing #1 SMP PREEMPT Wed Feb 18 21:05:30 CET 2009 i686 i686 i386 GNU/Linux
>
> with identical config and userspace (double-checked this time ;-)
> runs quite BUG-free.
>
A 2.6.28.6 -> 2.6.28.7 regressionlet.
This, I bet:
commit 2cf155b300c4839a7238b825c7c5f417e9d7cc68
Author: Jeremy Fitzhardinge <jeremy@goop.org>
Date: Wed Feb 11 09:32:19 2009 -0800
x86/cpa: make sure cpa is safe to call in lazy mmu mode
commit 4f06b0436b2ddbd3b67b10e77098a6862787b3eb upstream.
Impact: fix race leading to crash under KVM and Xen
The CPA code may be called while we're in lazy mmu update mode - for
example, when using DEBUG_PAGE_ALLOC and doing a slab allocation
in an interrupt handler which interrupted a lazy mmu update. In this
case, the in-memory pagetable state may be out of date due to pending
queued updates. We need to flush any pending updates before inspecting
the page table. Similarly, we must explicitly flush any modifications
CPA may have made (which comes down to flushing queued operations when
flushing the TLB).
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [2.6.28.7] BUG: using smp_processor_id() in preemptible [00000000] code: pageattr-test/207
2009-02-23 23:13 ` Andrew Morton
@ 2009-02-24 0:48 ` Tilman Schmidt
2009-02-24 8:30 ` Ingo Molnar
0 siblings, 1 reply; 7+ messages in thread
From: Tilman Schmidt @ 2009-02-24 0:48 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, stable, Jeremy Fitzhardinge, Ingo Molnar
On Mon, 23 Feb 2009 15:13:31 -0800, Andrew Morton <akpm@linux-foundation.org> wrote:
> A 2.6.28.6 -> 2.6.28.7 regressionlet.
>
> This, I bet:
>
> commit 2cf155b300c4839a7238b825c7c5f417e9d7cc68
> Author: Jeremy Fitzhardinge <jeremy@goop.org>
> Date: Wed Feb 11 09:32:19 2009 -0800
>
> x86/cpa: make sure cpa is safe to call in lazy mmu mode
>
> commit 4f06b0436b2ddbd3b67b10e77098a6862787b3eb upstream.
Jackpot! Reverted that commit on 2.6.28.7, and the BUG messages are gone.
Thanks,
Tilman
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [2.6.28.7] BUG: using smp_processor_id() in preemptible [00000000] code: pageattr-test/207
2009-02-24 0:48 ` Tilman Schmidt
@ 2009-02-24 8:30 ` Ingo Molnar
2009-02-24 8:40 ` Andrew Morton
2009-02-24 17:57 ` Tilman Schmidt
0 siblings, 2 replies; 7+ messages in thread
From: Ingo Molnar @ 2009-02-24 8:30 UTC (permalink / raw)
To: Tilman Schmidt; +Cc: Andrew Morton, linux-kernel, stable, Jeremy Fitzhardinge
* Tilman Schmidt <t.schmidt@phoenixsoftware.de> wrote:
> On Mon, 23 Feb 2009 15:13:31 -0800, Andrew Morton <akpm@linux-foundation.org> wrote:
> > A 2.6.28.6 -> 2.6.28.7 regressionlet.
> >
> > This, I bet:
> >
> > commit 2cf155b300c4839a7238b825c7c5f417e9d7cc68
> > Author: Jeremy Fitzhardinge <jeremy@goop.org>
> > Date: Wed Feb 11 09:32:19 2009 -0800
> >
> > x86/cpa: make sure cpa is safe to call in lazy mmu mode
> >
> > commit 4f06b0436b2ddbd3b67b10e77098a6862787b3eb upstream.
>
> Jackpot! Reverted that commit on 2.6.28.7, and the BUG messages are gone.
should be fixed by this as well:
d85cf93: x86/paravirt: make arch_flush_lazy_mmu/cpu disable preemption
Ingo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [2.6.28.7] BUG: using smp_processor_id() in preemptible [00000000] code: pageattr-test/207
2009-02-24 8:30 ` Ingo Molnar
@ 2009-02-24 8:40 ` Andrew Morton
2009-02-24 21:22 ` Ingo Molnar
2009-02-24 17:57 ` Tilman Schmidt
1 sibling, 1 reply; 7+ messages in thread
From: Andrew Morton @ 2009-02-24 8:40 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Tilman Schmidt, linux-kernel, stable, Jeremy Fitzhardinge
On Tue, 24 Feb 2009 09:30:28 +0100 Ingo Molnar <mingo@elte.hu> wrote:
>
> * Tilman Schmidt <t.schmidt@phoenixsoftware.de> wrote:
>
> > On Mon, 23 Feb 2009 15:13:31 -0800, Andrew Morton <akpm@linux-foundation.org> wrote:
> > > A 2.6.28.6 -> 2.6.28.7 regressionlet.
> > >
> > > This, I bet:
> > >
> > > commit 2cf155b300c4839a7238b825c7c5f417e9d7cc68
> > > Author: Jeremy Fitzhardinge <jeremy@goop.org>
> > > Date: Wed Feb 11 09:32:19 2009 -0800
> > >
> > > x86/cpa: make sure cpa is safe to call in lazy mmu mode
> > >
> > > commit 4f06b0436b2ddbd3b67b10e77098a6862787b3eb upstream.
> >
> > Jackpot! Reverted that commit on 2.6.28.7, and the BUG messages are gone.
>
> should be fixed by this as well:
>
> d85cf93: x86/paravirt: make arch_flush_lazy_mmu/cpu disable preemption
>
Yup, that patch got lost.
commit d85cf93da66977dbc645352be1b2084a659d8a0b
Author: Jeremy Fitzhardinge <jeremy@goop.org>
Date: Thu Feb 12 10:02:56 2009 -0800
x86/paravirt: make arch_flush_lazy_mmu/cpu disable preemption
from Linus mainline is needed in 2.6.28.8, please.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [2.6.28.7] BUG: using smp_processor_id() in preemptible [00000000] code: pageattr-test/207
2009-02-24 8:40 ` Andrew Morton
@ 2009-02-24 21:22 ` Ingo Molnar
0 siblings, 0 replies; 7+ messages in thread
From: Ingo Molnar @ 2009-02-24 21:22 UTC (permalink / raw)
To: Andrew Morton; +Cc: Tilman Schmidt, linux-kernel, stable, Jeremy Fitzhardinge
* Andrew Morton <akpm@linux-foundation.org> wrote:
> On Tue, 24 Feb 2009 09:30:28 +0100 Ingo Molnar <mingo@elte.hu> wrote:
>
> >
> > * Tilman Schmidt <t.schmidt@phoenixsoftware.de> wrote:
> >
> > > On Mon, 23 Feb 2009 15:13:31 -0800, Andrew Morton <akpm@linux-foundation.org> wrote:
> > > > A 2.6.28.6 -> 2.6.28.7 regressionlet.
> > > >
> > > > This, I bet:
> > > >
> > > > commit 2cf155b300c4839a7238b825c7c5f417e9d7cc68
> > > > Author: Jeremy Fitzhardinge <jeremy@goop.org>
> > > > Date: Wed Feb 11 09:32:19 2009 -0800
> > > >
> > > > x86/cpa: make sure cpa is safe to call in lazy mmu mode
> > > >
> > > > commit 4f06b0436b2ddbd3b67b10e77098a6862787b3eb upstream.
> > >
> > > Jackpot! Reverted that commit on 2.6.28.7, and the BUG messages are gone.
> >
> > should be fixed by this as well:
> >
> > d85cf93: x86/paravirt: make arch_flush_lazy_mmu/cpu disable preemption
> >
>
> Yup, that patch got lost.
>
> commit d85cf93da66977dbc645352be1b2084a659d8a0b
> Author: Jeremy Fitzhardinge <jeremy@goop.org>
> Date: Thu Feb 12 10:02:56 2009 -0800
>
> x86/paravirt: make arch_flush_lazy_mmu/cpu disable preemption
>
> from Linus mainline is needed in 2.6.28.8, please.
agreed.
Ingo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [2.6.28.7] BUG: using smp_processor_id() in preemptible [00000000] code: pageattr-test/207
2009-02-24 8:30 ` Ingo Molnar
2009-02-24 8:40 ` Andrew Morton
@ 2009-02-24 17:57 ` Tilman Schmidt
1 sibling, 0 replies; 7+ messages in thread
From: Tilman Schmidt @ 2009-02-24 17:57 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Andrew Morton, linux-kernel, stable, Jeremy Fitzhardinge
On Tue, 24 Feb 2009 09:30:28 +0100, Ingo Molnar <mingo@elte.hu> wrote:
> should be fixed by this as well:
>
> d85cf93: x86/paravirt: make arch_flush_lazy_mmu/cpu disable preemption
Confirmed.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-02-24 21:23 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-23 18:37 [2.6.28.7] BUG: using smp_processor_id() in preemptible [00000000] code: pageattr-test/207 Tilman Schmidt
2009-02-23 23:13 ` Andrew Morton
2009-02-24 0:48 ` Tilman Schmidt
2009-02-24 8:30 ` Ingo Molnar
2009-02-24 8:40 ` Andrew Morton
2009-02-24 21:22 ` Ingo Molnar
2009-02-24 17:57 ` Tilman Schmidt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.