All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drivers/net/rionet.c: remove some pointless conditionals before kfree_skb()
@ 2009-02-25 10:18 Wei Yongjun
  2009-02-27  7:08 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2009-02-25 10:18 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: netdev

Remove some pointless conditionals before kfree_skb().

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
 drivers/net/rionet.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/net/rionet.c b/drivers/net/rionet.c
index a6fd27a..ec59e29 100644
--- a/drivers/net/rionet.c
+++ b/drivers/net/rionet.c
@@ -362,8 +362,7 @@ static int rionet_close(struct net_device *ndev)
 	netif_carrier_off(ndev);
 
 	for (i = 0; i < RIONET_RX_RING_SIZE; i++)
-		if (rnet->rx_skb[i])
-			kfree_skb(rnet->rx_skb[i]);
+		kfree_skb(rnet->rx_skb[i]);
 
 	list_for_each_entry_safe(peer, tmp, &rionet_peers, node) {
 		if (rionet_active[peer->rdev->destid]) {
-- 
1.5.3.8





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers/net/rionet.c: remove some pointless conditionals before kfree_skb()
  2009-02-25 10:18 [PATCH] drivers/net/rionet.c: remove some pointless conditionals before kfree_skb() Wei Yongjun
@ 2009-02-27  7:08 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-02-27  7:08 UTC (permalink / raw)
  To: yjwei; +Cc: jgarzik, netdev

From: Wei Yongjun <yjwei@cn.fujitsu.com>
Date: Wed, 25 Feb 2009 18:18:12 +0800

> Remove some pointless conditionals before kfree_skb().
> 
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-02-27  7:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-25 10:18 [PATCH] drivers/net/rionet.c: remove some pointless conditionals before kfree_skb() Wei Yongjun
2009-02-27  7:08 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.