* [PATCH] snd-powermac: timeout reaches -1
@ 2009-02-25 12:40 Roel Kluin
2009-02-25 14:36 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-02-25 12:40 UTC (permalink / raw)
To: tiwai; +Cc: alsa-devel, Andrew Morton
If unsuccessful, timeout reaches -1 after the loop.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/sound/ppc/burgundy.c b/sound/ppc/burgundy.c
index f860d39..45a7629 100644
--- a/sound/ppc/burgundy.c
+++ b/sound/ppc/burgundy.c
@@ -35,7 +35,7 @@ snd_pmac_burgundy_busy_wait(struct snd_pmac *chip)
int timeout = 50;
while ((in_le32(&chip->awacs->codec_ctrl) & MASK_NEWECMD) && timeout--)
udelay(1);
- if (! timeout)
+ if (timeout < 0)
printk(KERN_DEBUG "burgundy_busy_wait: timeout\n");
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] snd-powermac: timeout reaches -1
2009-02-25 12:40 [PATCH] snd-powermac: timeout reaches -1 Roel Kluin
@ 2009-02-25 14:36 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2009-02-25 14:36 UTC (permalink / raw)
To: Roel Kluin; +Cc: alsa-devel, Andrew Morton
At Wed, 25 Feb 2009 13:40:26 +0100,
Roel Kluin wrote:
>
> If unsuccessful, timeout reaches -1 after the loop.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Applied now. Thanks.
Takashi
> ---
> diff --git a/sound/ppc/burgundy.c b/sound/ppc/burgundy.c
> index f860d39..45a7629 100644
> --- a/sound/ppc/burgundy.c
> +++ b/sound/ppc/burgundy.c
> @@ -35,7 +35,7 @@ snd_pmac_burgundy_busy_wait(struct snd_pmac *chip)
> int timeout = 50;
> while ((in_le32(&chip->awacs->codec_ctrl) & MASK_NEWECMD) && timeout--)
> udelay(1);
> - if (! timeout)
> + if (timeout < 0)
> printk(KERN_DEBUG "burgundy_busy_wait: timeout\n");
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-25 14:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-25 12:40 [PATCH] snd-powermac: timeout reaches -1 Roel Kluin
2009-02-25 14:36 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.