From: Karl Hiramoto <karl@hiramoto.org>
To: Christian Hohnstaedt <chohnstaedt@innominate.com>
Cc: linux-crypto@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>
Subject: Re:[PATCH] ixp4xx_crypto panic with fragmented packets in scatterlist
Date: Wed, 25 Feb 2009 16:35:40 +0100 [thread overview]
Message-ID: <49A5654C.1080002@hiramoto.org> (raw)
In-Reply-To: <49A55744.3010702@hiramoto.org>
[-- Attachment #1: Type: text/plain, Size: 104 bytes --]
The attached patch fixes my issue, but am not sure if it is correct or
will cause problems else where.
[-- Attachment #2: sg_chain.patch --]
[-- Type: text/plain, Size: 1200 bytes --]
diff -Naurp linux-2.6.28.7.a/arch/arm/include/asm/scatterlist.h linux-2.6.28.7.b/arch/arm/include/asm/scatterlist.h
--- linux-2.6.28.7.a/arch/arm/include/asm/scatterlist.h 2009-02-20 23:41:27.000000000 +0100
+++ linux-2.6.28.7.b/arch/arm/include/asm/scatterlist.h 2009-02-25 16:19:59.000000000 +0100
@@ -24,4 +24,6 @@ struct scatterlist {
#define sg_dma_address(sg) ((sg)->dma_address)
#define sg_dma_len(sg) ((sg)->length)
+#define ARCH_HAS_SG_CHAIN
+
#endif /* _ASMARM_SCATTERLIST_H */
diff -Naurp linux-2.6.28.7.a/crypto/eseqiv.c linux-2.6.28.7.b/crypto/eseqiv.c
--- linux-2.6.28.7.a/crypto/eseqiv.c 2009-02-20 23:41:27.000000000 +0100
+++ linux-2.6.28.7.b/crypto/eseqiv.c 2009-02-25 16:17:09.000000000 +0100
@@ -17,7 +17,6 @@
#include <crypto/internal/skcipher.h>
#include <crypto/rng.h>
-#include <crypto/scatterwalk.h>
#include <linux/err.h>
#include <linux/init.h>
#include <linux/kernel.h>
@@ -67,11 +66,11 @@ static void eseqiv_chain(struct scatterl
{
if (chain) {
head->length += sg->length;
- sg = scatterwalk_sg_next(sg);
+ sg = sg_next(sg);
}
if (sg)
- scatterwalk_sg_chain(head, 2, sg);
+ sg_chain(head, 2, sg);
else
sg_mark_end(head);
}
next prev parent reply other threads:[~2009-02-25 15:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-23 18:00 ixp4xx_crypto panic Karl Hiramoto
2009-02-24 13:19 ` ixp4xx_crypto panic with fragmented packets in scatterlist Karl Hiramoto
2009-02-25 9:07 ` Christian Hohnstaedt
2009-02-25 9:36 ` Karl Hiramoto
2009-02-25 11:54 ` Christian Hohnstaedt
2009-02-25 14:35 ` Karl Hiramoto
2009-02-25 15:35 ` Karl Hiramoto [this message]
2009-02-26 6:42 ` Herbert Xu
2009-02-26 9:55 ` [PATCH] " Russell King - ARM Linux
2009-02-26 12:10 ` Herbert Xu
2009-02-26 20:27 ` Karl Hiramoto
2009-02-27 10:26 ` Christian Hohnstaedt
2009-02-27 10:26 ` Christian Hohnstaedt
2009-02-26 23:20 ` Russell King - ARM Linux
2009-02-27 0:50 ` Herbert Xu
2009-03-02 11:45 ` [PATCH] crypto: fix handling of sg buffers in ixp4xx driver Christian Hohnstaedt
2009-03-02 20:42 ` Russell King - ARM Linux
2009-03-02 20:42 ` Russell King - ARM Linux
2009-03-03 3:02 ` Herbert Xu
2009-03-27 7:09 ` Herbert Xu
2009-03-27 7:09 ` Herbert Xu
2009-03-03 3:02 ` [PATCH] ixp4xx_crypto panic with fragmented packets in scatterlist Herbert Xu
2009-02-26 6:41 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49A5654C.1080002@hiramoto.org \
--to=karl@hiramoto.org \
--cc=chohnstaedt@innominate.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.