From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Christian Hohnstaedt <chohnstaedt@innominate.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
karl@hiramoto.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-k
Subject: Re: [PATCH] crypto: fix handling of sg buffers in ixp4xx driver
Date: Mon, 2 Mar 2009 20:42:39 +0000 [thread overview]
Message-ID: <20090302204239.GC25699@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20090302114511.GE6283@elara.bln.innominate.local>
On Mon, Mar 02, 2009 at 12:45:12PM +0100, Christian Hohnstaedt wrote:
>
> - keep dma functions away from chained scatterlists.
> Use the existing scatterlist iteration inside the driver
> to call dma_map_single() for each chunk and avoid dma_map_sg().
Hmm, interesting. So crypto has its own scatterlist chaining stuff which
is different and incompatible from what is supported by the rest of the
kernel.
That's really confusing. There's know way to know whether a struct scatterlist
should be walked by using the scatterwalk_* stuff or the generic stuff.
Excellent for reviewing.
So, sorry, I'm not qualified to review this. Please find someone else
who knows about crypto stuff.
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Christian Hohnstaedt <chohnstaedt@innominate.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
karl@hiramoto.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH] crypto: fix handling of sg buffers in ixp4xx driver
Date: Mon, 2 Mar 2009 20:42:39 +0000 [thread overview]
Message-ID: <20090302204239.GC25699@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20090302114511.GE6283@elara.bln.innominate.local>
On Mon, Mar 02, 2009 at 12:45:12PM +0100, Christian Hohnstaedt wrote:
>
> - keep dma functions away from chained scatterlists.
> Use the existing scatterlist iteration inside the driver
> to call dma_map_single() for each chunk and avoid dma_map_sg().
Hmm, interesting. So crypto has its own scatterlist chaining stuff which
is different and incompatible from what is supported by the rest of the
kernel.
That's really confusing. There's know way to know whether a struct scatterlist
should be walked by using the scatterwalk_* stuff or the generic stuff.
Excellent for reviewing.
So, sorry, I'm not qualified to review this. Please find someone else
who knows about crypto stuff.
next prev parent reply other threads:[~2009-03-02 20:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-23 18:00 ixp4xx_crypto panic Karl Hiramoto
2009-02-24 13:19 ` ixp4xx_crypto panic with fragmented packets in scatterlist Karl Hiramoto
2009-02-25 9:07 ` Christian Hohnstaedt
2009-02-25 9:36 ` Karl Hiramoto
2009-02-25 11:54 ` Christian Hohnstaedt
2009-02-25 14:35 ` Karl Hiramoto
2009-02-25 15:35 ` Karl Hiramoto
2009-02-26 6:42 ` Herbert Xu
2009-02-26 9:55 ` [PATCH] " Russell King - ARM Linux
2009-02-26 12:10 ` Herbert Xu
2009-02-26 20:27 ` Karl Hiramoto
2009-02-27 10:26 ` Christian Hohnstaedt
2009-02-27 10:26 ` Christian Hohnstaedt
2009-02-26 23:20 ` Russell King - ARM Linux
2009-02-27 0:50 ` Herbert Xu
2009-03-02 11:45 ` [PATCH] crypto: fix handling of sg buffers in ixp4xx driver Christian Hohnstaedt
2009-03-02 20:42 ` Russell King - ARM Linux [this message]
2009-03-02 20:42 ` Russell King - ARM Linux
2009-03-03 3:02 ` Herbert Xu
2009-03-27 7:09 ` Herbert Xu
2009-03-27 7:09 ` Herbert Xu
2009-03-03 3:02 ` [PATCH] ixp4xx_crypto panic with fragmented packets in scatterlist Herbert Xu
2009-02-26 6:41 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090302204239.GC25699@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=chohnstaedt@innominate.com \
--cc=herbert@gondor.apana.org.au \
--cc=karl@hiramoto.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.