* [PATCH RESEND] sched_rt: don't start timer when rt bandwidth disabled
@ 2009-02-25 17:59 Hiroshi Shimamoto
2009-02-25 18:41 ` Peter Zijlstra
0 siblings, 1 reply; 2+ messages in thread
From: Hiroshi Shimamoto @ 2009-02-25 17:59 UTC (permalink / raw)
To: Ingo Molnar, Peter Zijlstra; +Cc: linux-kernel
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Impact: fix incorrect condition check
No need to start rt bandwidth timer when rt bandwidth is disabled.
If this timer starts, it may stop at sched_rt_period_timer() on the first time.
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
---
kernel/sched.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index 4484f9c..9e49ac8 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -223,7 +223,7 @@ static void start_rt_bandwidth(struct rt_bandwidth *rt_b)
{
ktime_t now;
- if (rt_bandwidth_enabled() && rt_b->rt_runtime == RUNTIME_INF)
+ if (!rt_bandwidth_enabled() || rt_b->rt_runtime == RUNTIME_INF)
return;
if (hrtimer_active(&rt_b->rt_period_timer))
--
1.6.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH RESEND] sched_rt: don't start timer when rt bandwidth disabled
2009-02-25 17:59 [PATCH RESEND] sched_rt: don't start timer when rt bandwidth disabled Hiroshi Shimamoto
@ 2009-02-25 18:41 ` Peter Zijlstra
0 siblings, 0 replies; 2+ messages in thread
From: Peter Zijlstra @ 2009-02-25 18:41 UTC (permalink / raw)
To: Hiroshi Shimamoto; +Cc: Ingo Molnar, linux-kernel
Right, thanks for the reminder.
On Wed, 2009-02-25 at 09:59 -0800, Hiroshi Shimamoto wrote:
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>
> Impact: fix incorrect condition check
>
> No need to start rt bandwidth timer when rt bandwidth is disabled.
> If this timer starts, it may stop at sched_rt_period_timer() on the first time.
>
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Yep, looks like a good catch, thanks!
> ---
> kernel/sched.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/sched.c b/kernel/sched.c
> index 4484f9c..9e49ac8 100644
> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -223,7 +223,7 @@ static void start_rt_bandwidth(struct rt_bandwidth *rt_b)
> {
> ktime_t now;
>
> - if (rt_bandwidth_enabled() && rt_b->rt_runtime == RUNTIME_INF)
> + if (!rt_bandwidth_enabled() || rt_b->rt_runtime == RUNTIME_INF)
> return;
>
> if (hrtimer_active(&rt_b->rt_period_timer))
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-25 18:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-25 17:59 [PATCH RESEND] sched_rt: don't start timer when rt bandwidth disabled Hiroshi Shimamoto
2009-02-25 18:41 ` Peter Zijlstra
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.