From: Rik van Riel <riel@redhat.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] mm: don't free swap slots on page deactivation
Date: Wed, 25 Feb 2009 16:31:26 -0500 [thread overview]
Message-ID: <49A5B8AE.3060701@redhat.com> (raw)
In-Reply-To: <20090225192550.GA5645@cmpxchg.org>
Johannes Weiner wrote:
> The pagevec_swap_free() at the end of shrink_active_list() was
> introduced in 68a22394 "vmscan: free swap space on swap-in/activation"
> when shrink_active_list() was still rotating referenced active pages.
>
> In 7e9cd48 "vmscan: fix pagecache reclaim referenced bit check" this
> was changed, the rotating removed but the pagevec_swap_free() after
> the rotation loop was forgotten, applying now to the pagevec of the
> deactivation loop instead.
>
> Now swap space is freed for deactivated pages. And only for those
> that happen to be on the pagevec after the deactivation loop.
>
> Complete 7e9cd48 and remove the rest of the swap freeing.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Rik van Riel <riel@redhat.com>
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed.
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] mm: don't free swap slots on page deactivation
Date: Wed, 25 Feb 2009 16:31:26 -0500 [thread overview]
Message-ID: <49A5B8AE.3060701@redhat.com> (raw)
In-Reply-To: <20090225192550.GA5645@cmpxchg.org>
Johannes Weiner wrote:
> The pagevec_swap_free() at the end of shrink_active_list() was
> introduced in 68a22394 "vmscan: free swap space on swap-in/activation"
> when shrink_active_list() was still rotating referenced active pages.
>
> In 7e9cd48 "vmscan: fix pagecache reclaim referenced bit check" this
> was changed, the rotating removed but the pagevec_swap_free() after
> the rotation loop was forgotten, applying now to the pagevec of the
> deactivation loop instead.
>
> Now swap space is freed for deactivated pages. And only for those
> that happen to be on the pagevec after the deactivation loop.
>
> Complete 7e9cd48 and remove the rest of the swap freeing.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Rik van Riel <riel@redhat.com>
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-02-25 21:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 2:38 [patch] mm: move pagevec stripping to save unlock-relock Johannes Weiner
2009-02-25 2:38 ` Johannes Weiner
2009-02-25 8:13 ` MinChan Kim
2009-02-25 8:13 ` MinChan Kim
2009-02-25 19:25 ` [patch] mm: don't free swap slots on page deactivation Johannes Weiner
2009-02-25 19:25 ` Johannes Weiner
2009-02-25 20:40 ` Hugh Dickins
2009-02-25 20:40 ` Hugh Dickins
2009-03-01 10:37 ` [PATCH for mmotm] remove pagevec_swap_free() KOSAKI Motohiro
2009-03-01 10:37 ` KOSAKI Motohiro
2009-03-02 11:56 ` Hugh Dickins
2009-03-02 11:56 ` Hugh Dickins
2009-02-25 21:31 ` Rik van Riel [this message]
2009-02-25 21:31 ` [patch] mm: don't free swap slots on page deactivation Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49A5B8AE.3060701@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.